Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: community landing page #1119

Merged
merged 19 commits into from
Dec 7, 2022
Merged

feat: community landing page #1119

merged 19 commits into from
Dec 7, 2022

Conversation

AceTheCreator
Copy link
Member

@AceTheCreator AceTheCreator commented Nov 21, 2022

Community landing page implementation

Link to preview https://deploy-preview-1119--asyncapi-website.netlify.app/community

@AceTheCreator AceTheCreator changed the title Community home feat:community landing page Nov 21, 2022
@AceTheCreator AceTheCreator changed the title feat:community landing page feat: community landing page Nov 21, 2022
@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e818da
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/638f191afb494c00089954fb
😎 Deploy Preview https://deploy-preview-1119--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@quetzalliwrites
Copy link
Member

The spacing is fixed in mobile, great job! 🌟 🌟 🌟

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okidoki, left a review ✨✨✨✨

This is looking so much better @AceTheCreator, thank you for helping us keep moving this work along. 🙌🏽

akshatnema
akshatnema previously approved these changes Nov 30, 2022
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @AceTheCreator. It's perfect from my side. You should wait until @alequetzalli approval.

@derberg
Copy link
Member

derberg commented Dec 1, 2022

looks awesome to me. I only suggest, in ambassador section, put avatar of one of current ambassadors, not some random person. @alequetzalli is one of first ambassadors so is she only agrees, use her avatar there

Co-authored-by: Alejandra Quetzalli  <[email protected]>
AceTheCreator and others added 13 commits December 1, 2022 18:48
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
@AceTheCreator
Copy link
Member Author

Updated the PR with suggested changes

cc @alequetzalli @derberg @akshatnema

@quetzalliwrites
Copy link
Member

looks awesome to me. I only suggest, in ambassador section, put avatar of one of current ambassadors, not some random person. @alequetzalli is one of first ambassadors so is she only agrees, use her avatar there

omg this is soooo cool and nice, I would NEVER have expected or suggested this!! but also wow and thank you! 😂😄✌🏽

We have thousands of tutorials covering a wide range of
topics. Jump into our catalog!
Look into the AsyncAPI community building/maintenance goals
for 2023 and help us improve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for 2023 and help us improve
for 2023 and help us improve.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just 2 tiny fixes... one missing punctuation and there's a typo in the ambassador png that should be plural: Articles.

Fixed @alequetzalli

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just 2 tiny fixes... one missing punctuation and there's a typo in the ambassador png that should be plural: Articles.

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟🌟🌟

@akshatnema
Copy link
Member

This one is merging to the community branch and still we get 3 merge approvals 🤩

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit fa3e9fa into asyncapi:community Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants