fix: dashboard improvement #1108
Conversation
KhudaDad414
requested review from
fmvilas,
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1108--asyncapi-website.netlify.app/ |
|
@KhudaDad414 logs are not happy with your change: |
|
@derberg Oh my log, a sneaky comma 🤦 |
KhudaDad414
force-pushed
the
fix-dashboard
branch
from
0a032f9 to
b386b47
Compare
| @@ -142,7 +142,7 @@ async function start() { | |||
| ]); | |||
| writeToFile({ hotDiscussions, goodFirstIssues }); | |||
| } catch (e) { | |||
| writeToFile({ hotDiscussions: [], goodFirstIssues: [] }); | |||
There was a problem hiding this comment.
I have a question, why is the script getting errors on every 2nd-3rd iteration and catch block is implemented?
There was a problem hiding this comment.
Sometimes GitHub API returns internal server error and sometimes it says that you have reached your temporary limit (even if there is points remaining for that hour.)
I couldn't figure out what exactly the problem was.
There was a problem hiding this comment.
yeah, we are making quite some API calls to gather data 😅
There was a problem hiding this comment.
It can be possible that you are making multiple GET requests in a single second using the script, so it will exceed the Github API per second limit. You can better make the script sleep for 1-2 seconds if needed, to decrease the API calls in script per second.
There was a problem hiding this comment.
I agree this can be improved with simple delay or retry mechanism. Octokit had plugins for retry but for REST client, maybe they already have it for GraphQL.
Anyway I suggest ☝🏼 is solved as a followup because current bug is not nice and dashboard is empty again
|
/rtm |
Description