Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncAPI CodeGen blog #106

Merged
merged 25 commits into from
Jun 2, 2020
Merged

Conversation

Mrc0113
Copy link
Contributor

@Mrc0113 Mrc0113 commented May 20, 2020

Adding AsyncAPI Code Gen Blog using SCSt. Template

@netlify
Copy link

netlify bot commented May 20, 2020

Deploy preview for asyncapi-website ready!

Built with commit 705b056

https://deploy-preview-106--asyncapi-website.netlify.app

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 20, 2020

@derberg, adding my blog here. I think I fixed most things from the email

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mrc0113 Thanks a lot for this PR!
Please have a look at my comments. Some of them are blocking preview. Once you apply those basic fixes I'll have another look

content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 20, 2020

Thanks @derberg! I addressed the issues that you brought up when you removed. Hopefully the netlify preview will work now.

@derberg
Copy link
Member

derberg commented May 21, 2020

@Mrc0113 deploy is still broken, fix this tiny issue https://github.com/asyncapi/website/pull/106/files#r428562518

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 22, 2020

@derberg tiny issue fixed 👍

@derberg
Copy link
Member

derberg commented May 22, 2020

@Mrc0113 preview is here 🥳 https://deploy-preview-106--asyncapi-website.netlify.app/blog/asyncapi_codegen_scst/

You, please look on the issue with avatar and also review now content, if all is rendered as you expected. for code snippets remember to indicate what it is, for example "```bash"

I will review content now and check how we can fix those x-frame restrictions on netlify so you can nicely embed this youtube video

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 28, 2020

Updates made, outstanding:

  • I need to provide a new image (this one clashes...)
  • @derberg any idea why the styling doesn't show up for code marked "```java" ?
  • allow youtube video to show

@derberg
Copy link
Member

derberg commented May 28, 2020

I need to provide a new image (this one clashes...)

@Mrc0113 did you forget about something?

@derberg
Copy link
Member

derberg commented May 28, 2020

@Mrc0113 regarding youtube, I think it has to be fixed on a server side. We use Netlify so please at a root of repo, in your fork, create netlify.toml file with the following content:

X-Frame-Options: ALLOW

This should do the trick as I think by default they have SAMEORIGIN for security reasons, and we do not need it as we are as static as the iceberg that distroyed Titanic

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions to content,

I did not check with Grammarly as that would be lame from my side to check Native speaker 😄

content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
content/blog/asyncapi_codegen_scst.md Outdated Show resolved Hide resolved
netlify.toml Outdated Show resolved Hide resolved
@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 28, 2020

I need to provide a new image (this one clashes...)

@Mrc0113 did you forget about something?

The cover image doesn't look great; going to modify the current one...just waiting for the creator that has hte original to be online...should have it today 👍

netlify.toml Outdated
[[headers]]
for = "/*"
[headers.values]
X-Frame-Options = "ALLOW"
Copy link
Member

@derberg derberg May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, there is no allow directive here, should be allow-from, I'm not toml expert though
https://www.keycdn.com/blog/x-frame-options#3-allow-from-uri-directive
maybe this will work:
X-Frame-Options: "ALLOW-FROM https://www.youtube.com/"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying this, will definitely want to squash and merge 😆

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 28, 2020

@derberg Woohoo! The video is embedded. I'll try to get an updated image today and then that's the last update that I have.

@derberg
Copy link
Member

derberg commented May 29, 2020

@Mrc0113 you made it!
When you will upload the picture, please also set weight to 40, so it is featured on the very top on blog landing page. And yeah, adjust the date to a day where you want to have it visible, next Tuesday? (Mondays suck) or it doesn't matter for you?

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented May 29, 2020

@derberg, looks good to go to me. Set weight to 40 & date to next Tuesday as suggested 👍

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derberg
Copy link
Member

derberg commented Jun 1, 2020

@Mrc0113 hey, I change the publish date as you set Wednesday by mistake, I set Tuesday so it will also be mentioned in our newsletter

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented Jun 1, 2020

sounds good, thanks!

@derberg derberg merged commit 8e3dceb into asyncapi:master Jun 2, 2020
@Mrc0113 Mrc0113 deleted the add-codegen-blog branch June 2, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants