-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncAPI CodeGen blog #106
Conversation
Deploy preview for asyncapi-website ready! Built with commit 705b056 |
@derberg, adding my blog here. I think I fixed most things from the email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mrc0113 Thanks a lot for this PR!
Please have a look at my comments. Some of them are blocking preview. Once you apply those basic fixes I'll have another look
Thanks @derberg! I addressed the issues that you brought up when you removed. Hopefully the netlify preview will work now. |
@Mrc0113 deploy is still broken, fix this tiny issue https://github.com/asyncapi/website/pull/106/files#r428562518 |
Co-authored-by: Lukasz Gornicki <[email protected]>
@derberg tiny issue fixed 👍 |
@Mrc0113 preview is here 🥳 https://deploy-preview-106--asyncapi-website.netlify.app/blog/asyncapi_codegen_scst/ You, please look on the issue with avatar and also review now content, if all is rendered as you expected. for code snippets remember to indicate what it is, for example "```bash" I will review content now and check how we can fix those x-frame restrictions on netlify so you can nicely embed this youtube video |
Updates made, outstanding:
|
@Mrc0113 did you forget about something? |
@Mrc0113 regarding youtube, I think it has to be fixed on a server side. We use Netlify so please at a root of repo, in your fork, create
This should do the trick as I think by default they have SAMEORIGIN for security reasons, and we do not need it as we are as static as the iceberg that distroyed Titanic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions to content,
I did not check with Grammarly as that would be lame from my side to check Native speaker 😄
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
The cover image doesn't look great; going to modify the current one...just waiting for the creator that has hte original to be online...should have it today 👍 |
netlify.toml
Outdated
[[headers]] | ||
for = "/*" | ||
[headers.values] | ||
X-Frame-Options = "ALLOW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, there is no allow directive here, should be allow-from, I'm not toml expert though
https://www.keycdn.com/blog/x-frame-options#3-allow-from-uri-directive
maybe this will work:
X-Frame-Options: "ALLOW-FROM https://www.youtube.com/"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying this, will definitely want to squash and merge 😆
@derberg Woohoo! The video is embedded. I'll try to get an updated image today and then that's the last update that I have. |
@Mrc0113 you made it! |
@derberg, looks good to go to me. Set weight to 40 & date to next Tuesday as suggested 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Mrc0113 hey, I change the publish date as you set Wednesday by mistake, I set Tuesday so it will also be mentioned in our newsletter |
sounds good, thanks! |
Adding AsyncAPI Code Gen Blog using SCSt. Template