Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <Update Default Text for Buttons to Improve Clarity> #3500

Closed
2 tasks done
ChaitanyaKadu03 opened this issue Dec 20, 2024 · 7 comments
Closed
2 tasks done

[BUG] <Update Default Text for Buttons to Improve Clarity> #3500

ChaitanyaKadu03 opened this issue Dec 20, 2024 · 7 comments
Labels

Comments

@ChaitanyaKadu03
Copy link

ChaitanyaKadu03 commented Dec 20, 2024

Describe the bug.

The GoogleCalendarButton and ICSFileButton components on the Events Page use default text such as googleCalendarBtn, which appears to be a placeholder or untranslated key.

Expected behavior

The buttons should have clear, user-friendly default text that accurately describes their functionality, even if translation keys are used elsewhere. For example:

GoogleCalendarButton: Default text should be "Add to Google Calendar".
ICSFileButton: Default text should be "Download ICS File".
Screenshot 2024-12-21 014257

Screenshots

Screenshot 2024-12-21 011130

How to Reproduce

Update the default text values in the button components as follows:

  1. Update GoogleCalendarButton -
    text = 'Add to Google Calendar'

  2. Update ICSFileButton similarly -
    text = 'Download ICS File'

This is a minor UI/UX issue but can improve clarity by providing meaningful button labels by default.

🥦 Browser

Brave

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ChaitanyaKadu03
Copy link
Author

I'd like to propose a fix for this by updating the default text to something more user-friendly, like "Add to Google Calendar" and "Download ICS File.

Would it be okay for me to create a pull request addressing this? Let me know!
Thanks!

@Utkarsh-123github
Copy link
Contributor

@ChaitanyaKadu03 I have raised a PR that resolves this issue.

@BalrajDhakad
Copy link

I think the issue is suppose to be resolved in some other manner, you can have a look at #3488

@BalrajDhakad
Copy link

BalrajDhakad commented Dec 21, 2024

In the above mentioned PR I linked the text of the buttons to the common.json file where every text for a button is stored but it was still not the required solution.
In your (@Utkarsh-123github ) PR you have simply changed the hardcoded text on the button, which simply is not the goal.

@Utkarsh-123github
Copy link
Contributor

Utkarsh-123github commented Dec 21, 2024

@BalrajDhakad I think you misunderstood the issue and overcomplicating the solution. If there has to be made some changes then reviewers will respond to it.
Also if you check the codebase of SlackButton , then there the value is hard coded. If translation has to be done then there should be a translation for slack button too.
So let's wait for the reviewer to suggest changes.
Thanks for your suggestions.

@anshgoyalevil
Copy link
Member

Closing as duplicate to #3465

@anshgoyalevil anshgoyalevil closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants