-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: No form validation in Subscribe to our newsletter to receive news about AsyncAPI in home Page #2125
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Can anyone please assign this to me ? |
i think regExp won't work , it can't validate whether domain exits or not . Email validation api's like reacher , truemail would work |
yeah regex won't work. also can't be nicely completed until we get #1091 |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@derberg @akshatnema should we go ahead with this issue ?? |
Yeah, we can go ahead with this issue. |
@akshatnema, can I take it and work on it? All I need is to research around the Email validation API to verify the name and email of whoever is entering it. |
yeahhh you may work on this one |
@AKACHI-4 any update |
What I'm planning to do now is
Here's the image I was using :- |
Ohkkk great!! |
Raise a PR when you are done with the work |
Hey @sambhavgupta0705 .. I am done with the changes. kindly review it and guide for further in steps. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@sambhavgupta0705 Is this issue still relevant? I would like to work on it. |
yes you may |
can i work on it? |
I am currently not working on the issue, because of my exams. If you want you can start working on it :) |
Hey @sambhavgupta0705, I want to work on this issue an you please assign it to me? |
Hi @love-sonkar , |
Hi @derberg , Validation Changes for Email and Name InputsSummaryI added validation for the email and name input fields, ensuring error messages are displayed directly below their respective input fields for better clarity. Changes:
Untitled.video.-.Made.with.Clipchamp.1.mp4Please assign this issue to me, and I will submit the PR once the changes are approved. |
@derberg , @akshatnema please review above changes. |
Describe the bug
In Home page we have a Subscribe to our newsletter to receive news about AsyncAPI form and there is no validation for email and name.
How to Reproduce
Go to home page scroll down to subscribe to newsletter form and randomly enter any email or name then click on subscribe button.
chrome_29HnFrVdJ7.mp4
Expected behavior
Form must be completely valid
like email must be a valid email address.
and name must contain 3 or 4 character minimum.
The text was updated successfully, but these errors were encountered: