Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use netlify functions for email subscriptions instead of zapier #1091

Closed
derberg opened this issue Nov 9, 2022 · 23 comments · Fixed by #2315
Closed

use netlify functions for email subscriptions instead of zapier #1091

derberg opened this issue Nov 9, 2022 · 23 comments · Fixed by #2315
Assignees
Labels
bounty AsyncAPI Bounty program related label bounty/2023-Q4 AsyncAPI Bounty program related label enhancement level/advanced AsyncAPI Bounty program related label

Comments

@derberg
Copy link
Member

derberg commented Nov 9, 2022

Current state

Atm, when you go to one of those and provide email:

This info goes to Zapier, and then through some "magic" there done by @fmvilas subscriptions are created in MailChimp

Proposal

Subscription in MailChimp should be done through Netlify Functions. We already use them https://github.com/asyncapi/website/tree/master/netlify/functions.

We also already know MailChimp API as we had some integration already -> https://github.com/asyncapi/.github/blob/master/.github/workflows/scripts/mailchimp/index.js

Benefits

  • Zapier managed by one person is a bottleneck and also puts pressure on one person
  • Zapier costs money, and functions will not as we are not going to make lots of function calls anyway. I bet there are no more than few a week
  • More code in repo, more flexibility and better maintainability
  • Side effect, we can event improve the subscription UI component https://www.asyncapi.com/newsletter. So enable someone to subscribe to all segments (meetings and tsc) at the same time if they want.
  • will be much easier to add email subscriptions in conference website

Current issue

There is something wrong, we do not know where, probably zapier integration. And looks like that even if you subscribe for newsletter only, you get other emails too. Easier to check would be if we would see the code. Cause like in case of https://github.com/asyncapi/.github/blob/master/.github/workflows/scripts/mailchimp/index.js#L31 we at least see that we use MailChimp API in the way they documented to schedule email only for a given segment.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@AnishKacham
Copy link
Contributor

AnishKacham commented Aug 29, 2023

@derberg @akshatnema Are we sure that implementing the "proposal" will fix the "current issue" ? I'm assuming so, else they wouldn't be in the same issue 🙂 ?

@derberg
Copy link
Member Author

derberg commented Sep 4, 2023

@AnishKacham current issue is that Zapier is a paid service, so yeah, definitely switching to Netlify Functions is a fix 😄

@derberg
Copy link
Member Author

derberg commented Sep 5, 2023

@AnishKacham are you asking cause you plan to work on it? Please specify as we already have some plans for this one and need to know

@AnishKacham
Copy link
Contributor

@AnishKacham are you asking cause you plan to work on it? Please specify as we already have some plans for this one and need to know

I thought I would, but I think I'll look into #1368 this before as some work has already been done here and it was almost completed. That ok?

Copy link
Member Author

derberg commented Sep 6, 2023

sure, of course, thanks for clarification

@akshatnema
Copy link
Member

Thanks @AnishKacham

@reachaadrika, you have been assigned this task as the part of trial of idea called AsyncAPI Maintainership (as per @derberg 😅). Kindly complete it asap. Do let us know if you need any help on working in this issue.

@reachaadrika
Copy link
Contributor

reachaadrika commented Sep 6, 2023

cool , thanks for this will start off with this one

@akshatnema
Copy link
Member

@reachaadrika Kindly make sure you should test the Netlify functions correctly in local and in your fork, and notify me in the PR, whenever you create it.

@akshatnema
Copy link
Member

@reachaadrika Any updates on this?

@akshatnema
Copy link
Member

@reachaadrika Any updates so far?

@freakfan15
Copy link

Hi, Is this still up for grabs? I wanted to give it a go.

@akshatnema
Copy link
Member

Hey @freakfan15, this issue is under the AsyncAPI Bounty program and is under me. Actually, we selected this issue for the selection of maintainer candidates to evaluate them for their reviews. Thanks for taking the initiative, kindly choose another issue from the issues list to contribute to the project.

@freakfan15
Copy link

sure @akshatnema. Will do

@aeworxet aeworxet added bounty AsyncAPI Bounty program related label level/advanced AsyncAPI Bounty program related label bounty/2023-Q4 AsyncAPI Bounty program related label labels Nov 6, 2023
@aeworxet
Copy link
Contributor

aeworxet commented Nov 7, 2023

Bounty Issue's End Of Life (EOL): 2024-02-29 23:59:59 UTC-12:00

@aeworxet
Copy link
Contributor

aeworxet commented Nov 7, 2023

Bounty Issue's Timeline

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Advanced 2023-11-07 2023-11-13 2024-01-05 2023-12-01 2023-12-22 2024-01-05
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.

@derberg
Copy link
Member Author

derberg commented Nov 7, 2023

derberg assigned akshatnema 3 hours ago

I explicitly consulted with @akshatnema before submitting this issue to the bounty if I can add it and if he will have time to work on it:

  • this issue is critical and requires a lot of knowledge about the project
  • it was in the backlog for months already
  • we (me and @akshatnema) are in the process of onboarding 2 new maintainers and plan is that 1 candidate will act as main reviewer here, with me as backup

@aeworxet
Copy link
Contributor

Due to unpredicted circumstances that could not be foreseen and are beyond the control of the AsyncAPI Maintainer (@derberg), the Bounty Issue's Timeline is frozen for an indefinite amount of time.

@aeworxet
Copy link
Contributor

aeworxet commented Dec 6, 2023

AsyncAPI Maintainer (@derberg) had regained a confident online presence in Slack, so the Bounty Issue's Timeline is extended by four weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Advanced 2023-11-07 2023-11-13 2024-02-02 2023-12-29 2024-01-19 2024-02-02
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@aeworxet
Copy link
Contributor

aeworxet commented Jan 4, 2024

AsyncAPI Maintainer (@derberg) was absent online in Slack for one period of three working days in a row, so all remaining target dates of the Bounty Issue's Timeline are extended by two calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Advanced 2023-11-07 2023-11-13 2024-02-16 2024-01-12 2024-02-02 2024-02-16
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.

@derberg
Copy link
Member Author

derberg commented Jan 23, 2024

@aeworxet work completed in #2315

@fmvilas please make sure we do not automatically renew zapier subscription as these costs are no longer justified

@aeworxet
Copy link
Contributor

Bounty Issue Completed 🎉

@akshatnema, please go to the AsyncAPI's OpenCollective page and submit an invoice for USD 400.00 with the subject Bounty website#1091, tag bounty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label bounty/2023-Q4 AsyncAPI Bounty program related label enhancement level/advanced AsyncAPI Bounty program related label
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

7 participants