added changes based on review

asyncapi · Oct 11, 2024 · 8cbd9e3 · 8cbd9e3
1 parent 3a87764
commit 8cbd9e3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/components/Avatar.tsx b/components/Avatar.tsx
@@ -32,16 +32,17 @@ export default function Avatar({ name, photo, link, className }: AvatarProps) {
   );
 
   return link ? (
-    <span
+    <button
       onClick={(e) => {
         e.preventDefault();
 
         window.open(link, '_blank');
       }}
       data-testid='Avatars-link'
+      className='cursor-pointer border-none bg-inherit p-0'
     >
       {avatar}
-    </span>
+    </button>
   ) : (
     <React.Fragment>{avatar}</React.Fragment>
   );

diff --git a/components/navigation/BlogPostItem.tsx b/components/navigation/BlogPostItem.tsx
@@ -96,9 +96,10 @@ export default forwardRef(function BlogPostItem(
                       {post.authors
                         .map((author, index) =>
                           author.link ? (
-                            <span
+                            <button
                               key={index}
                               data-alt={author.name}
+                              className='cursor-pointer border-none bg-inherit p-0 hover:underline'
                               onClick={(e) => {
                                 e.preventDefault();
 
@@ -107,7 +108,7 @@ export default forwardRef(function BlogPostItem(
                               }}
                             >
                               {author.name}
-                            </span>
+                            </button>
                           ) : (
                             author.name
                           )

diff --git a/components/tools/ToolsCard.tsx b/components/tools/ToolsCard.tsx
@@ -92,7 +92,10 @@ export default function ToolsCard({ toolData }: ToolsCardProp) {
                   }, 500)
                 }
               >
-                <span ref={descriptionRef} className={`line-clamp-3 ${isTruncated && 'after:content-["..."]'}`}>
+                <span
+                  ref={descriptionRef}
+                  className={`line-clamp-3 inline-block ${isTruncated && 'after:ml-1 after:content-["..."]'}`}
+                >
                   {toolData.description}
                 </span>
               </span>