JSON Schema preview is broken

[kbolino]

Describe the bug

If I try to preview a JSON schema file which has no connection to AsyncAPI, I get a white page with black text that says only:

Error: The asyncapi field is missing.

How to Reproduce

Create a file test.schema.json with the following content:

{"$schema": "https://json-schema.org/draft-07/schema"}

Then click the "Preview AsyncAPI" button or Cmd+Shift+P (macOS) and select the option.

This appears to be identical to this issue from a similar plugin for IDEA.

Expected behavior

Either the preview option should be unavailable (because it doesn't work on this file type) or, even better, I should see a nice overview of the schema (assuming it was not trivial, like the example I gave).

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[ivangsa]

@kbolino thanks for reporting this issue.
We will fix this disabling AsyncAPI preview for non asyncapi files.

[Savio629]

So while debugging I found out that the isAsyncapi value could have caused the issue->

For asyncapi.yaml files

For asyncapi.json files

For non asyncapi (json) files

So by just adding the following condition AsyncAPI preview will be disable for non asyncapi files ->

Also for best practices would prefer using parenthesis here ->

[Savio629]

Should I open a pull request?

[asyncapi-bot]

🎉 This issue has been resolved in version 0.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀