Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

docs: add better examples and documentation #391

Merged

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Nov 30, 2021

Description

This PR adds better examples and documentation, similar to what is introduced to Modelina.

What is added:

  • new example setup, which includes usages and tests.
  • Adapted readme's to reflect new examples setup.
  • New workflow file to test that examples work

@jonaslagoni jonaslagoni changed the title docs: adding better examples and documentation docs: add better examples and documentation Nov 30, 2021
# Conflicts:
#	examples/publish subscribe/streetlight/lib/NatsTypescriptTemplateError.js
#	examples/publish subscribe/streetlight/lib/NatsTypescriptTemplateError.js.map
#	examples/publish subscribe/streetlight/lib/channels/StreetlightStreetlightIdCommandTurnon.d.ts
#	examples/publish subscribe/streetlight/lib/channels/StreetlightStreetlightIdCommandTurnon.js
#	examples/publish subscribe/streetlight/lib/channels/StreetlightStreetlightIdCommandTurnon.js.map
#	examples/publish subscribe/streetlight/lib/channels/StreetlightStreetlightIdEventTurnon.d.ts
#	examples/publish subscribe/streetlight/lib/channels/StreetlightStreetlightIdEventTurnon.js
#	examples/publish subscribe/streetlight/lib/channels/StreetlightStreetlightIdEventTurnon.js.map
#	examples/publish subscribe/streetlight/lib/index.d.ts
#	examples/publish subscribe/streetlight/lib/index.js
#	examples/publish subscribe/streetlight/lib/index.js.map
#	examples/publish subscribe/streetlight/lib/models/AnonymousSchema_1.d.ts
#	examples/publish subscribe/streetlight/lib/models/AnonymousSchema_1.js
#	examples/publish subscribe/streetlight/lib/models/AnonymousSchema_1.js.map
#	examples/publish subscribe/streetlight/lib/models/AnonymousSchema_3.d.ts
#	examples/publish subscribe/streetlight/lib/models/AnonymousSchema_3.js
#	examples/publish subscribe/streetlight/lib/models/AnonymousSchema_3.js.map
#	examples/publish subscribe/streetlight/lib/testclient/index.d.ts
#	examples/publish subscribe/streetlight/lib/testclient/index.js
#	examples/publish subscribe/streetlight/lib/testclient/index.js.map
#	examples/publish subscribe/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.d.ts
#	examples/publish subscribe/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.js
#	examples/publish subscribe/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.js.map
#	examples/publish subscribe/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdEventTurnon.d.ts
#	examples/publish subscribe/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdEventTurnon.js
#	examples/publish subscribe/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdEventTurnon.js.map
#	examples/publish subscribe/streetlight/package-lock.json
#	examples/publish subscribe/streetlight/src/channels/StreetlightStreetlightIdCommandTurnon.ts
#	examples/publish subscribe/streetlight/src/channels/StreetlightStreetlightIdEventTurnon.ts
#	examples/publish subscribe/streetlight/src/index.ts
#	examples/publish subscribe/streetlight/src/testclient/index.ts
#	examples/publish subscribe/streetlight/src/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.ts
#	examples/publish subscribe/streetlight/src/testclient/testchannels/StreetlightStreetlightIdEventTurnon.ts
#	examples/publish subscribe/streetlight/tests/integration/StreetlightStreetlightIdCommandTurnon.spec.ts
#	examples/publish subscribe/streetlight/tests/integration/StreetlightStreetlightIdEventTurnon.spec.ts
#	examples/request reply/streetlight/lib/NatsTypescriptTemplateError.js
#	examples/request reply/streetlight/lib/NatsTypescriptTemplateError.js.map
#	examples/request reply/streetlight/lib/channels/StreetlightStreetlightIdCommandTurnon.d.ts
#	examples/request reply/streetlight/lib/channels/StreetlightStreetlightIdCommandTurnon.js
#	examples/request reply/streetlight/lib/channels/StreetlightStreetlightIdCommandTurnon.js.map
#	examples/request reply/streetlight/lib/channels/StreetlightStreetlightIdEventTurnon.d.ts
#	examples/request reply/streetlight/lib/channels/StreetlightStreetlightIdEventTurnon.js
#	examples/request reply/streetlight/lib/channels/StreetlightStreetlightIdEventTurnon.js.map
#	examples/request reply/streetlight/lib/index.d.ts
#	examples/request reply/streetlight/lib/index.js
#	examples/request reply/streetlight/lib/index.js.map
#	examples/request reply/streetlight/lib/models/AnonymousSchema_1.d.ts
#	examples/request reply/streetlight/lib/models/AnonymousSchema_1.js
#	examples/request reply/streetlight/lib/models/AnonymousSchema_1.js.map
#	examples/request reply/streetlight/lib/models/AnonymousSchema_5.d.ts
#	examples/request reply/streetlight/lib/models/AnonymousSchema_5.js
#	examples/request reply/streetlight/lib/models/AnonymousSchema_5.js.map
#	examples/request reply/streetlight/lib/models/GeneralReply.d.ts
#	examples/request reply/streetlight/lib/models/GeneralReply.js
#	examples/request reply/streetlight/lib/models/GeneralReply.js.map
#	examples/request reply/streetlight/lib/testclient/index.d.ts
#	examples/request reply/streetlight/lib/testclient/index.js
#	examples/request reply/streetlight/lib/testclient/index.js.map
#	examples/request reply/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.d.ts
#	examples/request reply/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.js
#	examples/request reply/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.js.map
#	examples/request reply/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdEventTurnon.d.ts
#	examples/request reply/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdEventTurnon.js
#	examples/request reply/streetlight/lib/testclient/testchannels/StreetlightStreetlightIdEventTurnon.js.map
#	examples/request reply/streetlight/package-lock.json
#	examples/request reply/streetlight/src/channels/StreetlightStreetlightIdCommandTurnon.ts
#	examples/request reply/streetlight/src/channels/StreetlightStreetlightIdEventTurnon.ts
#	examples/request reply/streetlight/src/index.ts
#	examples/request reply/streetlight/src/testclient/index.ts
#	examples/request reply/streetlight/src/testclient/testchannels/StreetlightStreetlightIdCommandTurnon.ts
#	examples/request reply/streetlight/src/testclient/testchannels/StreetlightStreetlightIdEventTurnon.ts
#	examples/simple-reply/asyncapi-nats-client/API.md
#	examples/simple-request/asyncapi-nats-client/API.md
#	package-lock.json
# Conflicts:
#	examples/publish subscribe/streetlight/package-lock.json
#	examples/request reply/streetlight/package-lock.json
#	package-lock.json
@jonaslagoni jonaslagoni marked this pull request as ready for review December 14, 2021 13:46
@jonaslagoni
Copy link
Member Author

@alequetzalli do you mind reviewing the doc and example changes? 😄

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, finished my review, @jonaslagoni :)

@jonaslagoni
Copy link
Member Author

Ok, finished my review, @jonaslagoni :)

Thanks, @alequetzalli 🎉

Guess I didn't manage to fix the windows problem in time 🤣

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonaslagoni jonaslagoni requested a review from derberg December 17, 2021 12:36
@jonaslagoni jonaslagoni merged commit 5afa829 into asyncapi:master Dec 20, 2021
@jonaslagoni jonaslagoni deleted the feature/examples_and_documentations branch December 20, 2021 10:58
@jonaslagoni
Copy link
Member Author

@all-contributors please add @alequetzalli for review

@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @alequetzalli! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants