fix: scrollTo navigation to right code block #994
Conversation
Saumya40-codes
requested review from
magicmatatjahu,
KhudaDad414,
Amzani and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: c6f4106 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Saumya40-codes
changed the title
There was a problem hiding this comment.
Great work, @Saumya40-codes ! Just a small suggestion.
Thanks @satishkumarsajjan and @Vishal2002 for all your inputs.
…/studio into fix-scrollTo-yaml
Co-authored-by: Prince Rajpoot <[email protected]>
|
Hey @Amzani I've fixed the issue related to failed test (lint script)
|
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
@princerajpoot20 anything from your side? |
|
@KhudaDad414 All good. |
|
/rtm |
Description
scrollTo to a editor line was only working (correctly) for JSON files only.
The fix was to handle the case of YAML file separately.
AsyncAPI.Studio.-.Brave.2024-03-09.00-16-39.mp4
Related issue(s) Resolves #986
Thanks to @satishkumarsajjan and @Vishal2002 for all the feedbacks!!!