chore: add terminal #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
reviewed
Oct 1, 2021
There was a problem hiding this comment.
Got a few comments:
- Can you please update the parser dependency, as
2.2is not supported. - I get a "problem" that the terminal does not catch, I assume it is just a warning? That the AsyncAPI version is not supported. Anything that needs to be changed now?
- You don't want to add a few tests, or are you planning to create them afterwards 😟 ?
| <div | ||
| className="flex flex-row justify-between items-center px-2 border-b border-gray-700 text-white uppercase font-bold text-xs cursor-pointer" | ||
| onClick={e => { | ||
| const clientRects = e.currentTarget.parentElement?.parentElement?.getClientRects()[0]; |
There was a problem hiding this comment.
Yes 😅 I need to get how many pixels away from the bottom of an element so that the terminal closes itself on click - I am taking a few pixel adjustments to improve the UX.
magicmatatjahu
force-pushed
the
spa-scratch/terminal
branch
from
e2e6df1 to
2a233e8
Compare
|
I could make it disappear as well, no idea how, as I refreshed the window it reappeared. |
|
@jonaslagoni Ok, it should be fixed now :) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jonaslagoni Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Terminalcomponent like in VSCProblemstab in theTerminalcomponent to show all errors from our ParserJS: it shows all errors with appropriate lineRelated issue(s)
See also #80