Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add navigation #97

Merged
merged 2 commits into from
Sep 30, 2021
Merged

chore: add navigation #97

merged 2 commits into from
Sep 30, 2021

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Sep 30, 2021 •
edited
Loading

Description

  • add Navigation component next to editor and template.
  • add NavigationService with scrollTo functions - based on hashchange event.
  • add Sidebar component with the ability to hide the given block - navigation, editor or template.
  • add "stretching" functionality - navigation, editor, template can be stretched to the given horizontal size.
  • update relevant component like Content and main file.
  • add main.css file with styles for "stretching" functionality.

image

Related issue(s)
See also #80

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Sep 30, 2021
@magicmatatjahu magicmatatjahu mentioned this pull request Sep 30, 2021
Merged
@magicmatatjahu magicmatatjahu marked this pull request as ready for review September 30, 2021 08:49
jonaslagoni
jonaslagoni approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the branch protection of master to include review required to 1 😄

Just had a few points, but feel free to ignore it 😄

src/components/Content.tsx Outdated Show resolved Hide resolved
src/components/Navigation.tsx Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

@jonaslagoni Thanks! I propagated your suggestions :)

@magicmatatjahu magicmatatjahu merged commit b19c219 into asyncapi:spa-scratch Sep 30, 2021
@magicmatatjahu magicmatatjahu deleted the spa-scratch/navigation branch September 30, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicmatatjahu @jonaslagoni