feat: implement studio from scratch #88
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => { | ||
| getCLS(onPerfEntry); | ||
| getFID(onPerfEntry); | ||
| getFCP(onPerfEntry); | ||
| getLCP(onPerfEntry); | ||
| getTTFB(onPerfEntry); | ||
| }); |
There was a problem hiding this comment.
pretty cool @magicmatatjahu 💯 💯
Will Studio have Google Analytics? Perhaps we could send this info to analytics too (https://www.npmjs.com/package/web-vitals#user-content-send-the-results-to-google-analytics), does it make sense to do so?
Just asking because I think I saw some discussion on getting analytics from the playground, so Studio could have it too 🙂
What do you think?
There was a problem hiding this comment.
The file was created with create-react-app script, so it was added automatically. in future we will go with this as well as google analytics, but not now. Right now it's more important to get the Studio up and running. Google analytics and other things later :)
|
@magicmatatjahu what's missing in this PR? Can we get it out of draft mode maybe? |
|
@fmvilas Generally, I made the PR available with all the changes, and then I split it into separate PRs for better review. In the meantime I added/improved a dozen of things, so the PR is very behind with the changes on |
|
Oh true! I remember now. Thanks for the reminder 👍 |
Description
Related issue(s)
Proposal outcome #80