Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: set proper indentation for the TOC #853

Merged
merged 2 commits into from
Oct 28, 2022
Merged

docs: set proper indentation for the TOC #853

merged 2 commits into from
Oct 28, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Oct 17, 2022 •
edited
Loading

The TOC has some wrong indentation. This PR fixes that.

Note: this doesn't affect website navigation bar.

@smoya smoya changed the title fix: set proper indentation for the TOC docs: set proper indentation for the TOC Oct 17, 2022
@derberg
Copy link
Member

derberg commented Oct 18, 2022

This is not going to fix website. TOC from original markdown file is removed when it is pushed to website repo -> https://github.com/asyncapi/spec/blob/master/.github/workflows/new-spec-release.yml#L55

right-hand side nav/toc in the website is generated dynamically. Separate issue/PR is needed there

@smoya
Copy link
Member Author

smoya commented Oct 18, 2022

This is not going to fix website. TOC from original markdown file is removed when it is pushed to website repo -> https://github.com/asyncapi/spec/blob/master/.github/workflows/new-spec-release.yml#L55

right-hand side nav/toc in the website is generated dynamically. Separate issue/PR is needed there

That's actually what I needed to know. Thanks!

This PR is still valid for fixing the TOC in the spec document, even though it is a little detail. I'm changing the PR description to make it clear.

derberg
derberg approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoya
Copy link
Member Author

smoya commented Oct 18, 2022

FYI, issue created in website repo: asyncapi/website#1030

@smoya
Copy link
Member Author

smoya commented Oct 18, 2022

/rtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smoya
Copy link
Member Author

smoya commented Oct 28, 2022

/rtm

1 similar comment
@smoya
Copy link
Member Author

smoya commented Oct 28, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 9549230 into asyncapi:master Oct 28, 2022
@smoya
Copy link
Member Author

smoya commented Oct 28, 2022

/rtm

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Dec 4, 2023
Merged
jonaslagoni added a commit to jonaslagoni/spec that referenced this pull request Dec 4, 2023
@jonaslagoni
chore: apply asyncapi#853
ba8ea9d
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas fmvilas approved these changes

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smoya @derberg @asyncapi-bot @fmvilas @dalelane