-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve license application #783
docs: improve license application #783
Conversation
- use canonical version of the license - use license without rewording - use NOTICE file to provide copyright notice Refs asyncapi#711
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IANAL so this is a very hesitant "approve", but #711 makes a convincing argument :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTICE
looks consistent with the official statement -> https://infra.apache.org/apply-license.html. I made only one small suggestion
I'm not sure about modifications in LICENSE
file though. Official document is not clear and I see OpenAPI and CloudEvents folks do it the way we do it 🤔
Co-authored-by: Lukasz Gornicki <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Suggestion accepted, thanks.
Yes many projects do it like that. They modify the canonical license text, specifically the appendix which is intended to be copied to source file headers and then be modified. By doing this modification one can say that copyright notice is specific to the license text modification and not the creative work it tries to license. But again, I'm not a layer, I just proposed a way how to enhance the license application as recommended by Apache Foundation. |
it's just that ☝🏼 sounds like we should actually modify the license file with info about Linux Foundation. |
Right, so what is says is that if you have file called export const variable = 1; and want to apply the Apache 2.0 license to it explicitly, you take boilerplate from the license appendix, amend the copyright notice:
and apply it to the // Copyright 2021-2022 AsyncAPI Initiative
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
export const variable = 1; This is usually done in Java and C, C++ projects. Every file in the source code has a license header. That's why the licence talk about the file comment format: |
/au |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/rtm |
🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be |
🎉 This PR is included in version 2.5.0-next-spec.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Recent comments about the release from the bot were added by mistake. More details in #899 |
Refs #711
I understand that changing anything around the license is always very precarious. Nevertheless I've created this PR to demonstrate what I describe in #711.