-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: strip custom referencing mechanism from Channel Item #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
requested review from
fmvilas,
derberg,
dalelane and
asyncapi-bot-eve
as code owners
May 4, 2022 07:49
Kudos, SonarCloud Quality Gate passed! |
char0n
changed the title
feat: strip Channel Item from custom referencing mechanism
feat: strip custom referencing mechanism from Channel Item
May 4, 2022
This was referenced May 4, 2022
Closed
Link checker is producing errors in CI. Seems to be unrelated with my changeset. |
char0n
changed the title
feat: strip custom referencing mechanism from Channel Item
RFC: strip custom referencing mechanism from Channel Item
May 4, 2022
char0n
changed the title
RFC: strip custom referencing mechanism from Channel Item
feat: strip custom referencing mechanism from Channel Item
May 4, 2022
fmvilas
approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👏
/dnm |
derberg
approved these changes
May 10, 2022
Kudos, SonarCloud Quality Gate passed! |
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is attempt to get RFC(#699) from Stage 1 to Stage 2. It has already been stipulated in #607 that this is reasonable course of action which avoids future ambiguity and simplifies the specification.
Refs #699