Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a new release step to RELEASE_PROCESS.md #742

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 23, 2022

As @derberg caught in https://github.com/asyncapi/spec/pull/741/files#r833327198, we should also add a reference to the latest spec version in the README.md during the release process.

Related issue(s):
https://github.com/asyncapi/spec/pull/741/files#r833327198

derberg
derberg previously approved these changes Mar 23, 2022
dalelane
dalelane previously approved these changes Mar 23, 2022
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo of mine that you caught makes me sad. But apart from that - looks good! ;-)

@@ -23,7 +23,7 @@ Each release can have a different release coordinator. If you are interested and

Many of the steps needed to release a new version of the AsyncAPI specification (e.g. merging, creating branches, creating releases) need support from administrators for individual github.com/asyncapi repositories.

Each respository contains a `CODEOWNERS` file (e.g. https://github.com/asyncapi/parser-js/blob/master/CODEOWNERS) that identifies the people who can help.
Each repository contains a `CODEOWNERS` file (e.g. https://github.com/asyncapi/parser-js/blob/master/CODEOWNERS) that identifies the people who can help.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Copy link
Member Author

@smoya smoya Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how I noticed? Because I wrote respository (with the typo) in the search bar when editing the file. :)

RELEASE_PROCESS.md Outdated Show resolved Hide resolved
Co-authored-by: Fran Méndez <[email protected]>
@smoya smoya dismissed stale reviews from dalelane and derberg via 665ba89 March 24, 2022 09:49
@smoya smoya requested a review from fmvilas March 24, 2022 09:50
@smoya
Copy link
Member Author

smoya commented Mar 24, 2022

/rtm

@smoya
Copy link
Member Author

smoya commented Mar 24, 2022

/rtm

@smoya
Copy link
Member Author

smoya commented Mar 25, 2022

/help

@asyncapi-bot
Copy link
Contributor

Hello, @smoya! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in pull requests:

  • /ready-to-merge or /rtm - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
  • /do-not-merge or /dnm - This comment will block automerging even if all conditions are met and ready-to-merge label is added

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented Mar 28, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 9dd89a6 into asyncapi:master Mar 28, 2022
@smoya
Copy link
Member Author

smoya commented Mar 28, 2022

/rtm

Thanks 😅

@smoya smoya deleted the docs/releaseProcess branch March 28, 2022 10:15
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants