Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update release process #722

Merged
merged 16 commits into from
Mar 17, 2022

Conversation

dalelane
Copy link
Collaborator

Updates to the document used by the release coordinator
to help smooth the process for the next release.

Contributes to: #675

Signed-off-by: Dale Lane [email protected]

@dalelane dalelane force-pushed the update-release-process branch from 199f430 to 5259fb3 Compare February 12, 2022 15:02
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@dalelane dalelane changed the title docs: Update release process docs: update release process Feb 12, 2022
@dalelane
Copy link
Collaborator Author

dalelane commented Mar 1, 2022

I think there are more things that we should include for website updates - inspired by asyncapi/website#614 but from a quick search I can see other places that would justify attention, such as the examples in https://github.com/asyncapi/website/blob/master/pages/docs/getting-started/hello-world.md

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalelane sorry for being so late with review, added some comments

RELEASE_PROCESS.md Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Show resolved Hide resolved
RELEASE_PROCESS.md Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@dalelane dalelane marked this pull request as ready for review March 14, 2022 22:33
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@dalelane
Copy link
Collaborator Author

/rtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Mar 17, 2022

@dalelane I see you wanted to merge. It could not work as there were no approval. When you are done with updating PR basing on provided feedback remember about hitting the "arrows" icon that rerequests review and triggers notification to reviewers.

Screenshot 2022-03-17 at 12 22 42

anyway, great job and now I approve 🚀
you can try merge again 😄

@derberg
Copy link
Member

derberg commented Mar 17, 2022

@fmvilas not sure if you had a chance to see it so pinging you so you can see great job from Dale on improving the release process

@dalelane
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 9b8dff9 into asyncapi:master Mar 17, 2022
@smoya
Copy link
Member

smoya commented Mar 18, 2022

This is awesome it finally got merged 👏 Awesome stuff @dalelane ! thanks

@derberg
Copy link
Member

derberg commented Mar 18, 2022

now with each release goal should be to not add more steps, but remove as many manual steps as possible one by one 😅

@fmvilas
Copy link
Member

fmvilas commented Mar 21, 2022

Great stuff @dalelane 👏

@smoya smoya mentioned this pull request Mar 21, 2022
39 tasks
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants