Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codeowners file to enable people to also decide and not just bot 😄 #672

Merged
merged 1 commit into from
Dec 8, 2021
Merged

chore: fix codeowners file to enable people to also decide and not just bot 😄 #672

merged 1 commit into from
Dec 8, 2021

Conversation

derberg
Copy link
Member

@derberg derberg commented Dec 8, 2021

I have to admit that my initial CODEOWNER configuration was not the best, like future-proof, especially now for the permissions cleanup

@derberg derberg requested a review from fmvilas December 8, 2021 12:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Dec 8, 2021

/help

@asyncapi-bot
Copy link
Contributor

Hello, @fmvilas! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in pull requests:

  • /ready-to-merge or /rtm - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
  • /do-not-merge or /dnm - This comment will block automerging event if all conditions are met and ready-to-merge label is added

@fmvilas
Copy link
Member

fmvilas commented Dec 8, 2021

Sorry for the noise, was just playing with slash commands 😄

@derberg
Copy link
Member Author

derberg commented Dec 8, 2021

/rtm

@derberg derberg merged commit 0eb8f9d into asyncapi:master Dec 8, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.0-2022-01-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants