Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(spec): add RFC for Message Example Object #609

Merged
merged 5 commits into from
Sep 20, 2021

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Aug 10, 2021

This is formal proposal for introducing new Message Example Object as originally proposed by a strawman in #606. Champion of this RFC proposal is me (@char0n).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

spec/asyncapi.md Outdated Show resolved Hide resolved
spec/asyncapi.md Outdated Show resolved Hide resolved
spec/asyncapi.md Outdated Show resolved Hide resolved
char0n and others added 3 commits September 15, 2021 10:10
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀 🌔

@derberg
Copy link
Member

derberg commented Sep 20, 2021

@fmvilas linked proposal is at stage 1. Is this really docs: like change? There is also no implementation in the Parser atm (asyncapi/parser-js#321). This change would introduce Parser 2.0 release.

I'm all in with pushing it to the Parser and having 2.0 release, my feeling is that we have here a kind of unofficial fear of major releases, but I say I do not care that 2.0 will only have one new model, we should do it and improve UX and not look back (Jest.js had already 27 releases, React 17 and this is one of their strong points).

anyway, before we merge it, the proposal needs to reach stage 3 imho 🤷🏼

@char0n
Copy link
Collaborator Author

char0n commented Sep 20, 2021

@derberg how can I help to push this to stage 3?

@fmvilas
Copy link
Member

fmvilas commented Sep 20, 2021

@derberg I don't think this proposal should be linked to the one on the parser. To be honest, this is just a docs reorganization. I understand they're related but IMHO parser implementation of types shouldn't be a blocker for this one. Am I missing something?

@derberg
Copy link
Member

derberg commented Sep 20, 2021

@fmvilas I think you are right 👍🏼

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg derberg merged commit 4f3e5fd into asyncapi:master Sep 20, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants