-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(spec): add RFC for Message Example Object #609
docs(spec): add RFC for Message Example Object #609
Conversation
Kudos, SonarCloud Quality Gate passed! |
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀 🌔
@fmvilas linked proposal is at stage 1. Is this really I'm all in with pushing it to the Parser and having 2.0 release, my feeling is that we have here a kind of unofficial fear of major releases, but I say I do not care that 2.0 will only have one new model, we should do it and improve UX and not look back (Jest.js had already 27 releases, React 17 and this is one of their strong points). anyway, before we merge it, the proposal needs to reach stage 3 imho 🤷🏼 |
@derberg how can I help to push this to stage 3? |
@derberg I don't think this proposal should be linked to the one on the parser. To be honest, this is just a docs reorganization. I understand they're related but IMHO parser implementation of types shouldn't be a blocker for this one. Am I missing something? |
@fmvilas I think you are right 👍🏼 |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is formal proposal for introducing new Message Example Object as originally proposed by a strawman in #606. Champion of this RFC proposal is me (@char0n).