Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Create Anypoint MQ protocol and bindings #514

Closed
GeraldLoeffler opened this issue Mar 15, 2021 · 20 comments
Closed

[RFC] Create Anypoint MQ protocol and bindings #514

GeraldLoeffler opened this issue Mar 15, 2021 · 20 comments
Assignees
Labels
💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md)

Comments

@GeraldLoeffler
Copy link
Contributor

In trying to create AsyncAPI documents that assume Anypoint MQ as the message broker, It became apparent that this is not possible without binding objects for a new protocol for that broker.

I request anypointmq to be added to the list of protocols in AsyncAPI, and corresponding binding objects to be defined and added to https://github.com/asyncapi/bindings. These binding objects should describe, among other things:

  1. how to connect to an AnypointMQ broker instance using the server object
  2. how to use AnypointMQ queues (FIFO or not) and exchanges as channels
  3. how to use AnypointMQ message specifics like user properties, message ID, et.
@GeraldLoeffler
Copy link
Contributor Author

GeraldLoeffler commented Mar 15, 2021

Development of the requested bindings has been started in https://github.com/integrational/asyncapi-bindings/tree/master/anypointmq and a PR will be sent once sufficiently progressed.

@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@fmvilas fmvilas changed the title [FEATURE REQUEST] Create Anypoint MQ protocol and bindings [RFC] Create Anypoint MQ protocol and bindings Mar 16, 2021
@fmvilas fmvilas added 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) and removed feature request labels Mar 16, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label May 16, 2021
@GeraldLoeffler
Copy link
Contributor Author

will submit a minimal PR shortly

@GeraldLoeffler
Copy link
Contributor Author

This issue is addressed by these 2 PRs:

@GeraldLoeffler
Copy link
Contributor Author

This PR asyncapi/spec-json-schemas#67 covers the addition of the anypointmq protocol to the AsyncAPI JSON schema

@GeraldLoeffler
Copy link
Contributor Author

For reference: the AsyncAPI team has rejected the need for anypointmq as a protocol because the interaction with the Anypoint MQ broker is based on HTTP (for which a protocol already exists). I think this rejection stems from a basic disagreement about the purpose of a "protocol" in AsyncAPI. See asyncapi/bindings#63 (comment)

@derberg
Copy link
Member

derberg commented Jun 25, 2021

@GeraldLoeffler the PR is not closed without merge, thus it is not rejected 😉 it is in progress

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Aug 25, 2021
@derberg
Copy link
Member

derberg commented Aug 25, 2021

@GeraldLoeffler do you continue this one?

@GeraldLoeffler
Copy link
Contributor Author

@GeraldLoeffler do you continue this one?

as far as i'm aware @derberg this is complete in all its aspects: it just needs merging (into the spec and bindings repos).

@derberg
Copy link
Member

derberg commented Aug 25, 2021

PR in the binding repo is still not merged, there are some comments form my side

@derberg derberg removed the stale label Aug 25, 2021
@GeraldLoeffler
Copy link
Contributor Author

PR in the binding repo is still not merged, there are some comments form my side

oh i see - i thought this had been accepted weeks/months ago. I'll review your comments and incorporate them if possible.

@GeraldLoeffler
Copy link
Contributor Author

PR in the binding repo is still not merged, there are some comments form my side

done

@derberg derberg added 💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md) and removed 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) labels Sep 1, 2021
@derberg
Copy link
Member

derberg commented Sep 1, 2021

@GeraldLoeffler we are almost there. PR on binding repo is perfect. PR here in spec repo needs minor change (left comment) and we are missing PR to change JSON Schema, PR against 2021-09-release branch in https://github.com/asyncapi/spec-json-schemas. You can have a look on PR from Dale on IBM MQ binding to see how this should be changed so we see in PR only specific changes (you will need to create new JSON Schema file for new 2.2.0 version, this will be first commit, and then in the 2nd commit add new binding please)

@GeraldLoeffler
Copy link
Contributor Author

@GeraldLoeffler we are almost there. PR on binding repo is perfect. PR here in spec repo needs minor change (left comment) and we are missing PR to change JSON Schema, PR against 2021-09-release branch in https://github.com/asyncapi/spec-json-schemas. You can have a look on PR from Dale on IBM MQ binding to see how this should be changed so we see in PR only specific changes (you will need to create new JSON Schema file for new 2.2.0 version, this will be first commit, and then in the 2nd commit add new binding please)

i think i've now done all that @derberg . See asyncapi/spec-json-schemas#90 for the JSON Schema PR, and also note the strange files that appeared in that PR (asyncapi/spec-json-schemas#90 (comment)).

@GeraldLoeffler
Copy link
Contributor Author

note the strange files that appeared in that PR (asyncapi/spec-json-schemas#90 (comment)).

all cleaned-up, all ready: i assume this will go into 2.2.0?

@dalelane
Copy link
Collaborator

dalelane commented Jan 4, 2022

@GeraldLoeffler Is there anything left to do for this issue or do you think it's okay to close?

@GeraldLoeffler
Copy link
Contributor Author

that's been implemented @dalelane and i wasn't aware that there was this issue left open: please close it. Thank you.

@dalelane
Copy link
Collaborator

dalelane commented Jan 5, 2022

@derberg can you close, please? (I don't have the power 😁)

@derberg derberg closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md)
Projects
None yet
Development

No branches or pull requests

4 participants