Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add 2 manual steps for creating new versions #242

Merged
merged 1 commit into from
Jul 19, 2022
Merged

docs: add 2 manual steps for creating new versions #242

merged 1 commit into from
Jul 19, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Jul 13, 2022

Description

This PR adds 2 required manual steps for creating new versions.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

derberg
derberg approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇🏼

@smoya
Copy link
Member Author

smoya commented Jul 14, 2022

Cc @jonaslagoni in case u want to 👀 this.

@derberg
Copy link
Member

derberg commented Jul 19, 2022

@smoya in case you are waiting for all codeowners, it is just a docs change, feel free to merge once you have one approval. If some codeowner doesn't like that change after it is merged, it is easy to revert, easier than some big change in a library

@smoya
Copy link
Member Author

smoya commented Jul 19, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 24fb08c into asyncapi:master Jul 19, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released on @next-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smoya @derberg @asyncapi-bot @fmvilas