Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: application title bar and sidebar #142

Merged
merged 13 commits into from
Oct 26, 2022
Merged

feat: application title bar and sidebar #142

merged 13 commits into from
Oct 26, 2022

Conversation

NektariosFifes
Copy link
Collaborator

@NektariosFifes NektariosFifes commented Oct 21, 2022 •
edited
Loading

Capture

Description

  • Addition of stateful components Titlebar and SideBar
  • Basic Functionality to make sure state management works as intended

Related issue(s)
#88

@NektariosFifes NektariosFifes changed the title Application title bar and sidebar feat: Application title bar and sidebar Oct 21, 2022
@NektariosFifes NektariosFifes changed the title feat: Application title bar and sidebar feat: application title bar and sidebar Oct 21, 2022
@NektariosFifes
Copy link
Collaborator Author

NektariosFifes commented Oct 22, 2022 •
edited
Loading

i actually did not request review. it was done automatically.
There are some things i still have to go through

jonaslagoni
jonaslagoni previously approved these changes Oct 24, 2022
View reviewed changes
@jonaslagoni
Copy link
Member

i actually did not request review. it was done automatically. There are some things i still have to go through

Ahh okay 😄

@NektariosFifes
removed duplicates
04b9e84 
and some unused functios
NektariosFifes and others added 2 commits October 25, 2022 00:52
@NektariosFifes
changes
5092755 
-no longer using context but consumer for providing state to subcomponents.
-changes in  state definitions
-removed files that are out of the range of the commit
@NektariosFifes
Merge branch 'master' into ApplicationTitleBarAndSidebar
94ffe7e
@NektariosFifes
Copy link
Collaborator Author

NektariosFifes commented Oct 26, 2022 •
edited
Loading

i think it is ok now :) . i could add react component tests but i dont think it is needed yet.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jonaslagoni
jonaslagoni approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NektariosFifes NektariosFifes merged commit 05019b6 into asyncapi:master Oct 26, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NektariosFifes @jonaslagoni @asyncapi-bot