feat: add /bundle endpoint #70
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@Samridhi-98 Hi! Do you need some help? I know that PR is on draft stage but I see several problems, so I don't know if you wanna my review now or later :) |
Yeah, I need suggestions actually I made a few changes and haven't pushed yet that's why didn't ask. |
There was a problem hiding this comment.
@Samridhi-98 Awesome, but we need improve some things :) Please refer to my comments. When you propagate my suggestions, please ping me and I will tell you what you should do in next step to validate files/asyncapis field in proper way. Please don't do that in the main controller, please wait with it :)
|
@magicmatatjahu I have made the requested changes as per my understanding kindly let me know what should be the next step🙂 |
openapi.yaml
Outdated
| type: object | ||
| required: | ||
| - asyncapi | ||
| properties: | ||
| asyncapi: | ||
| $ref: "#/components/schemas/AsyncAPIDocument" |
There was a problem hiding this comment.
You can check this issue asyncapi/bundler#26 :) We should only pass files (asyncapis or single one file by asyncapi) and base object as optional field. asyncapis and asyncapi should be required (as union, only one should be sent).
|
@magicmatatjahu I am not able to figure out how to send data in a base field inside test☹ |
| channels: {}, | ||
| } | ||
| }) | ||
| .expect(200); |
There was a problem hiding this comment.
@Samridhi-98 You properly tested it 👏🏼 Please also check response data and everything will be ok.
|
@magicmatatjahu I am getting this error while checking for the response ☹ |
Samridhi-98
requested review from
smoya,
BOLT04 and
asyncapi-bot-eve
as code owners
|
@Samridhi-98 Sorry for such a delay. We have have there a big problem with circular references in the |
|
@magicmatatjahu Thank you so much for the help, it's working now 🙂 |
magicmatatjahu
force-pushed
the
feat/bundle
branch
from
8235f0f to
54da6bc
Compare
|
@Samridhi-98 Everything is ok, but I have to push one important commit on master first to make it possible to merge this PR, so please wait. |
No problem 😊 |
magicmatatjahu
force-pushed
the
feat/bundle
branch
from
8fc6447 to
2ddbc76
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@Samridhi-98 Thanks for contribution and patience! I hope you learned something new :) |
|
/rtm |
|
Hello, @magicmatatjahu! 👋🏼 |
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thank you so much for your help and guidance, Indeed great learning 😊 |
Description
openapi.yamlcontrolerandpackage.jsonRelated issue(s)
Fixes #55