Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable all official templates for generation #41

Merged
merged 6 commits into from
Feb 9, 2022
Merged

feat: enable all official templates for generation #41

merged 6 commits into from
Feb 9, 2022

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Jan 18, 2022 •
edited
Loading

Description

Enable all organization templates:

  • update openapi.yaml's enum with available templates

  • add to the dependencies missed templates:

    • '@asyncapi/dotnet-nats-template'
    • '@asyncapi/go-watermill-template'
    • '@asyncapi/java-spring-cloud-stream-template'
    • '@asyncapi/java-spring-template'
    • '@asyncapi/java-template'
    • '@asyncapi/nodejs-template'
    • '@asyncapi/nodejs-ws-template'
    • '@asyncapi/python-paho-template'
    • '@asyncapi/ts-nats-template'

  • add and update relevant unit tests

Related issue(s)
Resolves #40

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Jan 18, 2022
@magicmatatjahu magicmatatjahu changed the title feat: enable all organization templates feat: enable all official templates Jan 18, 2022
BOLT04
BOLT04 previously approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@magicmatatjahu magicmatatjahu changed the title feat: enable all official templates feat: enable all official templates for generation Feb 1, 2022
BOLT04
BOLT04 previously approved these changes Feb 1, 2022
View reviewed changes
@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Feb 9, 2022 •
edited
Loading

@BOLT04 Thanks for approve! However I had to bump deps to latest versions, so @smoya could you accept changes?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu requested a review from smoya February 9, 2022 14:07
smoya
smoya approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some testing on the 500 error. But as chatted offline, you would need to mock the generator, and for that I guess the code would need to follow dependency injection pattern (or maybe not? not familiar with mocking in JS).

Otherwise, LGTM 🚀 🌔

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit dcc8516 into asyncapi:master Feb 9, 2022
@magicmatatjahu magicmatatjahu deleted the enable-all-templates branch February 9, 2022 14:45
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@smoya smoya smoya approved these changes

@BOLT04 BOLT04 BOLT04 left review comments

Assignees
No one assigned
Labels
autoapproved enhancement New feature or request ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all templates from our organization available in the /generate path
4 participants
@magicmatatjahu @asyncapi-bot @smoya @BOLT04