Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile #24

Merged
merged 12 commits into from
Jan 14, 2022
Merged

feat: add Dockerfile #24

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b4d8c58
feat: add Dockerfile
magicmatatjahu Jan 4, 2022
9fada78
add githib workflow to push Docker image
magicmatatjahu Jan 4, 2022
7aca764
after review
magicmatatjahu Jan 5, 2022
2bed3a8
add .git dir to the .dockerignore
magicmatatjahu Jan 5, 2022
b8ebd79
after review
magicmatatjahu Jan 5, 2022
ad7f3ca
after review
magicmatatjahu Jan 5, 2022
3d174d0
add semantic release
magicmatatjahu Jan 5, 2022
d19a6f2
add semantic-release packages
magicmatatjahu Jan 5, 2022
a90a9bc
move generate:docker script
magicmatatjahu Jan 5, 2022
a546b77
add publishConfig to the package.json
magicmatatjahu Jan 14, 2022
798d738
change version in the package.json to the 0.0.1
magicmatatjahu Jan 14, 2022
e09002f
remove publishConfig
magicmatatjahu Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@
"ts-node": "^10.2.1",
"typescript": "^4.4.3"
},
"publishConfig": {
"access": "public"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why this is needed but It's because you know, not familiar with it at all. Would you mind explaining quickly to me, please 🙏 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah it's only for release on npm, which we don't do. I'll have to remove that and let you know. But the general idea is to be able to publish the public version on npm the scoped packages (in our case @asyncapi/*), which by default is restricted. More info https://docs.npmjs.com/cli/v8/using-npm/config#access

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok removed, @smoya Could you check again? Thanks! :)

},
"release": {
"branches": [
"master"
Expand Down