Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eslint integration #20

Merged
merged 4 commits into from
Dec 14, 2021
Merged

chore: eslint integration #20

merged 4 commits into from
Dec 14, 2021

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Dec 14, 2021 •
edited
Loading

Description

Changes:

  • Eslint integration:
    • add eslint config file with these rules like in studio or modelina repos with little updated related to server app character
    • fix errors
  • Change all sync code to async to improve performance, mainly read/write files

Related issue(s)
Resolves #14

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Dec 14, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smoya
smoya approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one concern to me regarding the cost of going with async for everything.
I'm not very up-to-date with what's Node cost on promises but as far as you @magicmatatjahu are aware of it and confident, LGTM 👍

@magicmatatjahu
Copy link
Member Author

@BOLT04 Do you want add something? :)

BOLT04
BOLT04 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@magicmatatjahu magicmatatjahu merged commit 301075e into asyncapi:master Dec 14, 2021
@magicmatatjahu magicmatatjahu deleted the eslint-integration branch December 14, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BOLT04 BOLT04 BOLT04 approved these changes

@smoya smoya smoya approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Eslint
3 participants
@magicmatatjahu @smoya @BOLT04