Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: initialize repository #2
chore: initialize repository #2
Changes from 10 commits
842427d
e40fe1f
3e1e8e0
63ea955
2b56f82
31595e6
b4411cb
3b3feb2
212ffb3
a84a0ce
6899385
0923b09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the right code if someone gives the wrong body shape - e.g. not allowed
template
field or invalid AsyncAPI. Any thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
422
is used whenever the syntaxis is correct and understandable by your server, meaning the JSON or YAML is valid, but semantically it isn't, like your example ofnot allowed template field
. So in this case, makes sense to me.However, for the other example
invalid AsyncAPI
,400
status code fits better since it will mean the syntaxis is wrong.So I think we can add both status codes so we can differentiate the source of the errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In first iteration we will only support these two templates.