feat: add Dockerfile #24
Conversation
magicmatatjahu
force-pushed
the
dockerfile
branch
from
a38ff4d to
a90a9bc
Compare
|
@smoya Could you accept again? I had to add: "publishConfig": {
"access": "public"
},to the package.json as well change version from |
package.json
Outdated
| @@ -91,6 +91,9 @@ | |||
| "ts-node": "^10.2.1", | |||
| "typescript": "^4.4.3" | |||
| }, | |||
| "publishConfig": { | |||
| "access": "public" | |||
There was a problem hiding this comment.
I don't fully understand why this is needed but It's because you know, not familiar with it at all. Would you mind explaining quickly to me, please 🙏 ?
There was a problem hiding this comment.
Hah it's only for release on npm, which we don't do. I'll have to remove that and let you know. But the general idea is to be able to publish the public version on npm the scoped packages (in our case @asyncapi/*), which by default is restricted. More info https://docs.npmjs.com/cli/v8/using-npm/config#access
There was a problem hiding this comment.
Ok removed, @smoya Could you check again? Thanks! :)
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@asyncapi/server-api", | |||
| "version": "0.1.0", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
As this version is already released it seems: https://github.com/asyncapi/server-api/releases/tag/v0.0.1
Would this be bumped automatically when releasing next version?
There was a problem hiding this comment.
Yes, it will be bumped, but semantic release check latest version and make bumps on that, so we have placeholder 0.0.1 release on Github to start next release - 0.1.0 :)
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add Dockerfile and related things which we will mainly use in Kubernetes deployment for
api.asyncapi.comdomain: