fix: update @async/specs to version 4.0.0 and fix tests (#188) (#202)

openapi.yaml

@@ -291,11 +291,6 @@ components:
       type: string
       description: Valid specification versions for the AsyncAPI document.
       enum:
-        - '1.0.0'
-        - '1.1.0'
-        - '1.2.0'
-        - '2.0.0-rc1'
-        - '2.0.0-rc2'
         - '2.0.0'
         - '2.1.0'
         - '2.2.0'

package.json

@@ -59,7 +59,7 @@
     "@asyncapi/parser": "^1.17.2",
     "@asyncapi/python-paho-template": "^0.2.13",
     "@asyncapi/raml-dt-schema-parser": "^2.0.1",
-    "@asyncapi/specs": "^3.2.1",
+    "@asyncapi/specs": "^4.0.1",
     "@asyncapi/ts-nats-template": "^0.10.1",
     "ajv": "^8.8.2",
     "ajv-formats": "^2.1.1",

src/controllers/tests/convert.controller.test.ts

@@ -15,6 +15,15 @@ const validJsonAsyncAPI2_0_0 = {
   channels: {}
 };
 
+const validJsonAsyncAPI2_1_0 = {
+  asyncapi: '2.1.0',
+  info: {
+    title: 'Super test',
+    version: '1.0.0'
+  },
+  channels: {}
+};
+
 const validYamlAsyncAPI2_3_0 = `
 asyncapi: 2.4.0
 info:
@@ -67,14 +76,14 @@ describe('ConvertController', () => {
       return request(app.getServer())
         .post('/v1/convert')
         .send({
-          asyncapi: validJsonAsyncAPI2_0_0,
-          version: '1.2.0'
+          asyncapi: validJsonAsyncAPI2_1_0,
+          version: '2.0.0'
         })
         .expect(422, {
           type: 'https://api.asyncapi.com/problem/internal-converter-error',
           title: 'Could not convert document',
           status: 422,
-          detail: 'Cannot downgrade from 2.0.0 to 1.2.0.',
+          detail: 'Cannot downgrade from 2.1.0 to 2.0.0.',
         });
     });
 

src/services/convert.service.ts

@@ -19,11 +19,11 @@ export class ConvertService {
    */
   public async convert(
     spec: string | AsyncAPIDocument,
-    version: SpecsEnum = LAST_SPEC_VERSION,
+    version: SpecsEnum = LAST_SPEC_VERSION as SpecsEnum,
     language?: 'json' | 'yaml' | 'yml',
   ): Promise<string> {
     if (version === 'latest') {
-      version = LAST_SPEC_VERSION;
+      version = LAST_SPEC_VERSION as SpecsEnum;
     }
 
     try {

src/services/tests/convert.service.test.ts

@@ -10,6 +10,15 @@ const validJsonAsyncAPI2_0_0 = {
   channels: {}
 };
 
+const validJsonAsyncAPI2_1_0 = {
+  asyncapi: '2.1.0',
+  info: {
+    title: 'Super test',
+    version: '1.0.0'
+  },
+  channels: {}
+};
+
 const validYamlAsyncAPI2_4_0 = `
 asyncapi: 2.4.0
 info:
@@ -23,9 +32,9 @@ describe('ConvertService', () => {
 
   describe('.convert()', () => {
     it('should throw error that the converter cannot convert to a lower version', async () => {
-      let err: ProblemException;
+      let err: ProblemException | null = null;
       try {
-        await convertService.convert(validJsonAsyncAPI2_0_0, '1.2.0');
+        await convertService.convert(validJsonAsyncAPI2_1_0, '2.0.0');
       } catch (e) {
         err = e;
       }
@@ -34,7 +43,7 @@ describe('ConvertService', () => {
         type: 'internal-converter-error',
         title: 'Could not convert document',
         status: 422,
-        detail: 'Cannot downgrade from 2.0.0 to 1.2.0.',
+        detail: 'Cannot downgrade from 2.1.0 to 2.0.0.',
       }));
     });