chore: update next-spec with latest master #691
Conversation
…lows/scripts/mailchimp (asyncapi#667)
Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
AceTheCreator
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
🤔 We got a failing test. Any idea why this is happening? @magicmatatjahu |
|
Anyway, this is not a concern of this PR so feel free to merge. Remember to merge using the "Merge commit" strategy instead of the "Squash and merge" one. |
I don't know 🤷🏼 I don't think so that in the failing test the ajv try to create the new reference for each validation function. I have to check that, so yeah, please merge it and I will apply fix (probably on release branch). |
|
I think I need your approvals @magicmatatjahu, @jonaslagoni |
|
/rtm |
|
Yeah, we can't merge if this test is not passing. We should be fixing it on another PR pointing to |
|
@AceTheCreator Please add new commits from master and try to merge it :) |
AceTheCreator
dismissed stale reviews from magicmatatjahu, fmvilas, and derberg
via
418810a
|
Kudos, SonarCloud Quality Gate passed!
|
|
All tests passed, thanks to @magicmatatjahu |
|
/rtm |
|
🎉 This PR is included in version 1.17.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-next-major.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR updates next-spec branch with changes from master.
cc @fmvilas @derberg