Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle complex circular reference cases #671

Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix: handle complex circular reference cases #671

merged 3 commits into from
Nov 8, 2022

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Nov 8, 2022 •
edited
Loading

Description

Support edge circular reference cases:

  • resolve circular refs to appropriate resolved object in JSON tree.
  • update SchemaV2 and SchemaOld models.
  • remove unnecessary functions.
  • update unit test.

Related issue(s)
Resolves #599

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Nov 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jonaslagoni
jonaslagoni approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit d9c3be0 into asyncapi:next-major Nov 8, 2022
@magicmatatjahu magicmatatjahu deleted the next/handle-circular-edges branch November 8, 2022 13:41
@magicmatatjahu magicmatatjahu mentioned this pull request Nov 8, 2022
Closed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready-to-merge released on @next-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @asyncapi-bot @jonaslagoni