Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: port security scheme model to ts #513

Merged
merged 4 commits into from
Apr 28, 2022
Merged

refactor: port security scheme model to ts #513

merged 4 commits into from
Apr 28, 2022

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Apr 6, 2022

Description
Porting server-variable object to typescript.

Related issue(s)

See also #482

@Souvikns Souvikns marked this pull request as ready for review April 12, 2022 08:35
@Souvikns
Copy link
Member Author

@magicmatatjahu should I add the flow object in this PR?

@magicmatatjahu
Copy link
Member

@Souvikns Go ahead :) The sooner we rewrite the models the better.

@Souvikns
Copy link
Member Author

@magicmatatjahu, @smoya can you clarify that AuthFlows object in the server-api has been updated. It does not follow the has, get, all, isEmpty format we are following for other collections.

@Souvikns
Copy link
Member Author

Ready for review 🤞🏻

@magicmatatjahu
Copy link
Member

@Souvikns sorry for such a long delay.

can you clarify that AuthFlows object in the server-api has been updated. It does not follow the has, get, all, isEmpty format we are following for other collections.

AuthFlows Object isn't collection but object, so we don't treat it as collection :)

magicmatatjahu
magicmatatjahu requested changes Apr 28, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR we should remove one field and we will implement it in next PRs - we have bug in parser-api. I will handle that. Rest is good 🚀

src/models/server.ts Outdated Show resolved Hide resolved
src/models/v2/server.ts Outdated Show resolved Hide resolved
src/models/v3/server.ts Outdated Show resolved Hide resolved
test/models/v2/server.spec.ts Outdated Show resolved Hide resolved
test/models/v2/server.spec.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 30 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

magicmatatjahu
magicmatatjahu approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu magicmatatjahu merged commit 6b208c7 into asyncapi:next-major Apr 28, 2022
magicmatatjahu pushed a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
@Souvikns @magicmatatjahu
refactor: port security scheme model to ts (asyncapi#513)
7f0fed5
derberg pushed a commit that referenced this pull request Oct 4, 2022
@Souvikns @derberg
refactor: port security scheme model to ts (#513)
b7845cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Souvikns @magicmatatjahu