Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for messageId #510

Merged
merged 10 commits into from
Apr 22, 2022
Merged

feat: add support for messageId #510

merged 10 commits into from
Apr 22, 2022

Conversation

WaleedAshraf
Copy link
Contributor

@WaleedAshraf WaleedAshraf commented Apr 1, 2022 •
edited
Loading

Description

  • add support for messageId
  • If messageId is present, check for duplicates
  • messageId takes precedence in message.uid() method
  • update/add tests

Related issue(s)
closes #414

magicmatatjahu
magicmatatjahu requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good but we need improvements :)

lib/customValidators.js Show resolved Hide resolved
lib/customValidators.js Show resolved Hide resolved
lib/customValidators.js Outdated Show resolved Hide resolved
test/customValidators_test.js Show resolved Hide resolved
@smoya smoya mentioned this pull request Apr 5, 2022
Closed
55 tasks
@derberg derberg mentioned this pull request Apr 11, 2022
Closed
@magicmatatjahu
Copy link
Member

@WaleedAshraf I made rereview :) We should fix only think, related to the oneOf messages. Rest is good.

magicmatatjahu
magicmatatjahu approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member

@smoya Could we merge it as next prerelease?

@magicmatatjahu magicmatatjahu changed the base branch from master to 2022-04-release April 19, 2022 14:12
@smoya
Copy link
Member

smoya commented Apr 19, 2022

@smoya Could we merge it as next prerelease?

There are pending things still to work on the spec PR asyncapi/spec#458

@smoya
Copy link
Member

smoya commented Apr 20, 2022

@WaleedAshraf would you mind fixing merge conflicts? We are very close to merge all the PR's of your new contribution!

@WaleedAshraf
Copy link
Contributor Author

WaleedAshraf commented Apr 20, 2022 •
edited
Loading

@smoya @magicmatatjahu It's showing changes in .github folder because 2022-04-release branch is not up to date with master. Maybe you should do that, before merging this?

@WaleedAshraf WaleedAshraf force-pushed the issue-414 branch 2 times, most recently from 9aff5a7 to 679dcee Compare April 20, 2022 16:36
@WaleedAshraf
Copy link
Contributor Author

link checker is failing because this link is updated,
https://apidevtools.org/json-schema-ref-parser/docs/options.html

to this,
https://apitools.dev/json-schema-ref-parser/docs/options.html

I'm not sure why it wasn't caught in recent PRs by @smoya
Can someone fix this in the release branch? and I'll rebase.

@derberg
Copy link
Member

derberg commented Apr 21, 2022

Hey, since you edited API.md there are some broken links discovered with one of CI checks. There are 2 options:

  • fix links
  • or just remove any changes to API.md as we will anyway rebuild it by CI after release

@WaleedAshraf
Copy link
Contributor Author

@derberg still fails. It seems the checker is using the base branch.

derberg
derberg approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magicmatatjahu please also approve again, just to make sure you are ok as I see you revied and approved before

@magicmatatjahu
Copy link
Member

@derberg Accepted. Please merge when you want.

@smoya
Copy link
Member

smoya commented Apr 22, 2022

Good news @WaleedAshraf! We are almost done with merging your feature into the release branch! 🎉
However, for merging this PR, I need to ask you to:

  • Fix the conflicts with the upstream branch (2022-04-release)
  • Update @asyncapi/specs package to the latest prereleased version (which includes your changes). It is v2.14.0-2022-04-release.3.

Once you push those changes, all will be ready to merge this. Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@WaleedAshraf
Copy link
Contributor Author

@smoya Done 🎉

@smoya
Copy link
Member

smoya commented Apr 22, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit d3ee61c into asyncapi:2022-04-release Apr 22, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0-2022-04-release.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@WaleedAshraf WaleedAshraf deleted the issue-414 branch April 22, 2022 20:00
@magicmatatjahu magicmatatjahu mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
ready-to-merge released on @2022-04-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for messageId
6 participants
@WaleedAshraf @magicmatatjahu @smoya @derberg @asyncapi-bot @LokeshRishi