Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add stringify functionality #486

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

  • Add stringify and unstringify functions - it's copy of the static methods of AsyncAPIDocument
  • Add needed helpers
  • Add extensions that we will use in next PRs
  • Add relevant unit tests

Related issue(s)
Part of #482
Part of #421

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu requested a review from smoya March 9, 2022 10:18
@magicmatatjahu magicmatatjahu changed the title chore: add stringify functionality refactor: add stringify functionality Mar 9, 2022
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit f08ad28 into asyncapi:next-major Mar 9, 2022
@magicmatatjahu magicmatatjahu deleted the next/stringify branch March 9, 2022 11:12
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
derberg pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants