Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseFromUrl does not resolve relative references #504

Closed
jonaslagoni opened this issue Mar 25, 2022 · 4 comments · Fixed by #572
Closed

parseFromUrl does not resolve relative references #504

jonaslagoni opened this issue Mar 25, 2022 · 4 comments · Fixed by #572
Labels
bug Something isn't working released on @next-major released

Comments

@jonaslagoni
Copy link
Member

Describe the bug

Given the use of parseFromUrl I would expect that if the remote document contained relative references, they would be resolved based on the URL passed to parseFromUrl 🤔

How to Reproduce

Given a reference such as "$ref": "./components/parameters.json#/server_id" in an AsyncAPI document located at https://raw.githubusercontent.com/org/repo/main/asyncapi.json I would expect it to fetch the parameter from https://raw.githubusercontent.com/org/repo/main/components/parameters.json#/server_id instead of trying to fetch it locally on the machine.
@jonaslagoni jonaslagoni added the bug Something isn't working label Mar 25, 2022
@derberg
Copy link
Member

derberg commented Jul 18, 2022

@jonaslagoni just to be sure, this is feature request, not really a bug. Especially that if someone wants to do that what you just described has an option to pass custom resolver to parseFromUrl. We just do not provide such a resolver out of the box

@jonaslagoni
Copy link
Member Author

@derberg that would make sense yes.

aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 18, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
e7d657a
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 19, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
6963e8d
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 19, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
adab6a8
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 19, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
89034a1
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 19, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
a510a6e
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 19, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
3288ba9
@aeworxet aeworxet mentioned this issue Jul 19, 2022
Merged
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Jul 20, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
1344ba1
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Aug 31, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
1b38074
aeworxet added a commit to aeworxet/asyncapi-parser-js that referenced this issue Sep 1, 2022
@aeworxet
feat: parseFromUrl does not resolve relative references (asyncapi#504)
3f11dc9
jonaslagoni added a commit to aeworxet/asyncapi-parser-js that referenced this issue Sep 14, 2022
@jonaslagoni
Merge branch 'master' into parseFromUrl-does-not-resolve-relative-ref…
9a912a4 
…erences-asyncapi#504
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.0.0-next-major.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @next-major released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: parseFromUrl does not resolve relative references (#504) aeworxet/asyncapi-parser-js
3 participants
@derberg @jonaslagoni @asyncapi-bot