-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support AsyncAPI spec v3 #193
Conversation
@derberg @jonaslagoni would appreciate some feedback. 🙏 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@derberg pingy pongy. 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I guess better to wait with merge before changes are done to enable operations under components.
Also maybe this should go out as 1.0
There are a few more things that need to change for v1. like supporting all components and changing the Report generation format. |
@KhudaDad414 so now there are no breaking changes here? all good working with v2 documents? |
@derberg yes. it is compatible with v3 and v2. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@derberg tests were failing. can you approve it again, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rtm |
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description:
debug
module and debugging logs.Note 1: After merging this PR some components like
traits
won't be optimised since from this point forward we are not going to parse the AsyncAPI file here, the parser is doing it. (Read more here: asyncapi/parser-api#109)fixes asyncapi/parser-js#168, fixes asyncapi/parser-js#192, fixes asyncapi/parser-js#173