-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test that check project generation using snapshot testing #103
Conversation
@fmvilas now I know why I did not use |
I'm not opinionated but Sonar Cloud says:
I don't think it's our case here. We should be fine with random. If an attacker guesses the next random number, good for them! 😂 |
@fmvilas I'm not afraid of a real security issues, these are tests. Just that there are 2 options:
I prefer first option as it means one less file 😄 |
Isn't there a way to ignore SonarCloud on that line only? Like Another option is not to use |
@fmvilas love it, added |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 0.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR is the best example that shows how to add to template tests based on snapshot testing. All files in the PR are needed for any other project except for: