Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dalelane as a contributor for code, ideas #183

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

allcontributors[bot]
Copy link
Contributor

Add @dalelane as a contributor for code, ideas.

This was requested by magicmatatjahu in this comment

@jonaslagoni
Copy link
Member

I have the same problem that the tests are not being executed, which means you have to manually disable security rules for you to merge using administrator rights...

Not sure how we can fix it.

@magicmatatjahu
Copy link
Member

@jonaslagoni I think that allcontributors bot is excluded from these jobs and they don't run. Maybe @derberg can help.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu merged commit 67fe714 into master Oct 11, 2021
@magicmatatjahu magicmatatjahu deleted the all-contributors/add-dalelane branch October 11, 2021 14:52
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Oct 12, 2021

So far I have no idea how to fix this. These jobs are required, there is no way to require a given job conditionally. But these tests do not run as allcontributors bot makes a commit with skip ci text 🤷🏼

So workflows are not triggered but required, and we are stuck. Even if in the workflow we make some condition, it won't work as workflow do not fire anyway.

The only solution I see is https://allcontributors.org/docs/en/bot/configuration, but only once we start supporting mirroring of additional files by global workflows support action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants