Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding request/reply content in module-3 #11

Closed
wants to merge 3 commits into from

Conversation

TRohit20
Copy link

Description
As part of creating a 100-level interactive learning path for AsyncAPI, adding the content for module 3.

Outline for the content to be present in the module from this pull request:

Module-3: AsyncAPI Specification

  • Understanding the structure of an AsyncAPI document.
  • request/reply

Spaceship fixed, we see Chan leaving to his planet on his spaceship

NOTE: This PR is the 3rd and final PR used to add content for module-3

@TRohit20
Copy link
Author

TRohit20 commented Jan 30, 2024

Since Lukasz is currently on time off, I request @smoya to have a look and review the content, suggest changes(if any required) or approve if it all looks good.

Context: The PR is part of multiple PRs covering different sections of a single module(3):

Thanks!

CC @alequetzalli

@quetzalliwrites
Copy link
Member

@TRohit20 I think you inadvertently may confuse Sergio with the PR order you discussed above... 😸

I would recommend instead you make a simple 3 point bullet list showing him the order of the PRs and title what each one covers.

@TRohit20
Copy link
Author

Done @alequetzalli

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there are 3 PR's opened pointing to the exact same file step2.md.

Please unify all of those into one single PR so we can review the file as a whole.

cc @TRohit20 @mhmohona @alequetzalli

@TRohit20 TRohit20 closed this Feb 14, 2024
TRohit20 added a commit to TRohit20/learning-paths that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants