-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding request/reply content in module-3 #11
Conversation
Since Lukasz is currently on time off, I request @smoya to have a look and review the content, suggest changes(if any required) or approve if it all looks good. Context: The PR is part of multiple PRs covering different sections of a single module(3):
Thanks! CC @alequetzalli |
@TRohit20 I think you inadvertently may confuse Sergio with the PR order you discussed above... 😸 I would recommend instead you make a simple 3 point bullet list showing him the order of the PRs and title what each one covers. |
Done @alequetzalli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there are 3 PR's opened pointing to the exact same file step2.md
.
- docs: add content for module 3 #5
- docs: adding content for module 3 #9
- docs: adding request/reply content in module-3 #11
Please unify all of those into one single PR so we can review the file as a whole.
Description
As part of creating a 100-level interactive learning path for AsyncAPI, adding the content for module 3.
Outline for the content to be present in the module from this pull request:
Module-3: AsyncAPI Specification
Spaceship fixed, we see Chan leaving to his planet on his spaceship
NOTE: This PR is the 3rd and final PR used to add content for module-3