feat: Add Kotlin module to model resolver (#48)

feat - Add Kotlin module to model resolver
asyncapi · Apr 10, 2023 · 04d6162 · 04d6162
1 parent 3ea409b
commit 04d6162
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 14 deletions.
diff --git a/kotlin-asyncapi-spring-web/pom.xml b/kotlin-asyncapi-spring-web/pom.xml
@@ -31,6 +31,10 @@
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.module</groupId>
+            <artifactId>jackson-module-kotlin</artifactId>
+        </dependency>
         <dependency>
             <groupId>io.swagger.core.v3</groupId>
             <artifactId>swagger-core</artifactId>

diff --git a/...in/org/openfolder/kotlinasyncapi/springweb/context/annotation/processor/ConverterUtils.kt b/...in/org/openfolder/kotlinasyncapi/springweb/context/annotation/processor/ConverterUtils.kt
@@ -0,0 +1,9 @@
+package org.openfolder.kotlinasyncapi.springweb.context.annotation.processor
+
+import com.fasterxml.jackson.module.kotlin.registerKotlinModule
+import io.swagger.v3.core.converter.ModelConverters
+import io.swagger.v3.core.jackson.ModelResolver
+
+internal val MODEL_RESOLVER = ModelConverters().also {
+    (it.converters.first() as ModelResolver).objectMapper().registerKotlinModule()
+}
diff --git a/.../org/openfolder/kotlinasyncapi/springweb/context/annotation/processor/MessageProcessor.kt b/.../org/openfolder/kotlinasyncapi/springweb/context/annotation/processor/MessageProcessor.kt
@@ -1,6 +1,5 @@
 package org.openfolder.kotlinasyncapi.springweb.context.annotation.processor
 
-import io.swagger.v3.core.converter.ModelConverters
 import org.openfolder.kotlinasyncapi.annotation.channel.Message
 import org.openfolder.kotlinasyncapi.model.Reference
 import org.openfolder.kotlinasyncapi.model.component.Components
@@ -10,8 +9,7 @@ import kotlin.reflect.KClass
 @Component
 internal class MessageProcessor : AnnotationProcessor<Message, KClass<*>> {
     override fun process(annotation: Message, context: KClass<*>): Components {
-        val converters = ModelConverters()
-        val jsonSchema = converters.readAll(context.java)
+        val jsonSchema = MODEL_RESOLVER.readAll(context.java)
 
         return Components().apply {
             messages {

diff --git a/...n/org/openfolder/kotlinasyncapi/springweb/context/annotation/processor/SchemaProcessor.kt b/...n/org/openfolder/kotlinasyncapi/springweb/context/annotation/processor/SchemaProcessor.kt
@@ -1,6 +1,5 @@
 package org.openfolder.kotlinasyncapi.springweb.context.annotation.processor
 
-import io.swagger.v3.core.converter.ModelConverters
 import org.openfolder.kotlinasyncapi.annotation.Schema
 import org.openfolder.kotlinasyncapi.model.component.Components
 import org.springframework.stereotype.Component
@@ -9,8 +8,7 @@ import kotlin.reflect.KClass
 @Component
 internal class SchemaProcessor : AnnotationProcessor<Schema, KClass<*>> {
     override fun process(annotation: Schema, context: KClass<*>): Components {
-        val converters = ModelConverters()
-        val jsonSchema = converters.readAll(context.java)
+        val jsonSchema = MODEL_RESOLVER.readAll(context.java)
 
         return Components().apply {
             schemas {

diff --git a/...g/openfolder/kotlinasyncapi/springweb/context/annotation/processor/SchemaProcessorTest.kt b/...g/openfolder/kotlinasyncapi/springweb/context/annotation/processor/SchemaProcessorTest.kt
@@ -25,7 +25,7 @@ internal class SchemaProcessorTest {
         val id: Int = 0,
         val name: String,
         val isTest: Boolean,
-        val sub: TestSubSchema
+        val sub: TestSubSchema?
     )
 
     data class TestSubSchema(

diff --git a/kotlin-asyncapi-spring-web/src/test/resources/annotation/annotation_integration.json b/kotlin-asyncapi-spring-web/src/test/resources/annotation/annotation_integration.json
@@ -58,6 +58,7 @@
   },
   "schemas" : {
     "TestHeaders" : {
+      "required" : [ "type" ],
       "type" : "object",
       "properties" : {
         "type" : {
@@ -69,6 +70,7 @@
       "exampleSetFlag" : false
     },
     "TestMessage" : {
+      "required" : [ "id", "isTest", "name" ],
       "type" : "object",
       "properties" : {
         "id" : {
@@ -82,7 +84,7 @@
           "exampleSetFlag" : false,
           "types" : [ "string" ]
         },
-        "test" : {
+        "isTest" : {
           "type" : "boolean",
           "exampleSetFlag" : false,
           "types" : [ "boolean" ]

diff --git a/kotlin-asyncapi-spring-web/src/test/resources/annotation/message_component.json b/kotlin-asyncapi-spring-web/src/test/resources/annotation/message_component.json
@@ -18,6 +18,7 @@
   },
   "schemas" : {
     "TestPayload" : {
+      "required" : [ "id", "isTest", "name" ],
       "type" : "object",
       "properties" : {
         "id" : {
@@ -31,7 +32,7 @@
           "exampleSetFlag" : false,
           "types" : [ "string" ]
         },
-        "test" : {
+        "isTest" : {
           "type" : "boolean",
           "exampleSetFlag" : false,
           "types" : [ "boolean" ]

diff --git a/kotlin-asyncapi-spring-web/src/test/resources/annotation/schema_component.json b/kotlin-asyncapi-spring-web/src/test/resources/annotation/schema_component.json
@@ -1,6 +1,7 @@
 {
   "schemas" : {
     "TestSchema" : {
+      "required" : [ "id", "isTest", "name" ],
       "type" : "object",
       "properties" : {
         "id" : {
@@ -14,19 +15,20 @@
           "exampleSetFlag" : false,
           "types" : [ "string" ]
         },
-        "sub" : {
-          "$ref" : "#/components/schemas/TestSubSchema",
-          "exampleSetFlag" : false
-        },
-        "test" : {
+        "isTest" : {
           "type" : "boolean",
           "exampleSetFlag" : false,
           "types" : [ "boolean" ]
+        },
+        "sub" : {
+          "$ref" : "#/components/schemas/TestSubSchema",
+          "exampleSetFlag" : false
         }
       },
       "exampleSetFlag" : false
     },
     "TestSubSchema" : {
+      "required" : [ "exists" ],
       "type" : "object",
       "properties" : {
         "exists" : {

diff --git a/pom.xml b/pom.xml
@@ -245,6 +245,11 @@
                 <artifactId>jackson-databind</artifactId>
                 <version>2.14.2</version>
             </dependency>
+            <dependency>
+                <groupId>com.fasterxml.jackson.module</groupId>
+                <artifactId>jackson-module-kotlin</artifactId>
+                <version>2.14.2</version>
+            </dependency>
             <dependency>
                 <groupId>io.swagger.core.v3</groupId>
                 <artifactId>swagger-core</artifactId>