fix: work with cycle defendant properties

[Tenischev]

Description

• use json-decycle to remove schema cycles for JSON.stringify
• during testing found issue with parser, reported here Handling of circular refs in spec is broken parser-js#293 (comment)
• tested with

components:
  messages:
    lightMeasured:
      summary: Inform about environmental lighting conditions for a particular streetlight.
      payload:
        $ref: "#/components/schemas/lightMeasuredPayload"
  schemas:
    lightMeasuredPayload:
      type: object
      properties:
        lumens:
          type: integer
          minimum: 0
          description: Light intensity measured in lumens.
        childs:
          type: array
          items:
            $ref: "#/components/schemas/lightMeasuredPayload"

Related issue(s)
Fixes: #150

[derberg]

@Tenischev as @magicmatatjahu recently released new parser-js with function dedicated to stringify securely (handles circular deps like a pro) AsyncAPI document, and it is already in the generator:

• you can remove decycle
• in package.json update that template will work only with generator "generator": ">=1.8.27 <2.0.0",
• this is how you access the stringify function now asyncapi.constructor.stringify(asyncapi)

[derberg]

@Tenischev btw mate, I see you are still using the template because you are still improving it, don't you want to join as a maintainer? so except for pushing your stuff, you would have to also support us on review or other PRs and triaging existing issues

[Tenischev]

@derberg thanks for the advice, I redid it

And regarding your suggestions, yes it would be interesting for me.

btw, Merry Christmas! 🎅

[derberg]

@Tenischev

Merry Christmassssss!

Please also remove json-decycle from package.json, and also changes in package-lock.json should not be reflected in this PR.

And regarding your suggestions, yes it would be interesting for me.

Perfect, do you know anyone who would like to join you, or would it have to be me until we find someone?

[derberg]

@Tenischev yo man, back at work already? 😄

[Tenischev]

Not yet :), tomorrow last day of vacation
I will fix it within next days

[derberg]

oh lucky you!!! enjoy!

[Tenischev]

@derberg package and package-lock are fixed.

Perfect, do you know anyone who would like to join you, or would it have to be me until we find someone?

Unfortunately, no, so it's going to be you 😄

[derberg]

@Tenischev 😭 😆 please open up a PR to add codeowners and add us there. Also specify if you can help us on org level and want to join TSC 😉

[derberg]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 0.25.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀