-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add magicmatatjahu as a contributor #190
Conversation
@magicmatatjahu gonna merge this for you 😄 |
Kudos, SonarCloud Quality Gate passed! |
Someone removed |
@jonaslagoni I removed it at the beginning of the file and add it to the end 😅 I had to have badges in this same line, not one under second, I took this "workaround" from one of the issues in all-contributors projects, but if it brokes the functionality so ok, and sorry for that 😅 |
Hehe, yea all-contributors dont know where to change the badge otherwise 😄 Related issue: all-contributors/all-contributors#361 |
@jonaslagoni So as I understand, the problem was with that badge was at the end, not at the beginning of file, so maybe this workaround works, but I made fakup and added it at the end? 🤣 I didn't notice any bug with this approach in mentioned issue. |
I mean, badges are usually displayed at the start 😄 don't know how well it looks having it in the bottom 😅 but you can try and create a PR 😄 |
@jonaslagoni It (badge) will show at the beginning, but I made reference to badge at the end of file, but it should be probably at the beginning :) I had this in my mind. |
🎉 This PR is included in version 0.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds @magicmatatjahu as a contributor for code, test, bug.
This was requested by magicmatatjahu in this comment