Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add magicmatatjahu as a contributor #190

Merged
merged 4 commits into from
May 10, 2021

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @magicmatatjahu as a contributor for code, test, bug.

This was requested by magicmatatjahu in this comment

magicmatatjahu
magicmatatjahu previously approved these changes May 6, 2021
@jonaslagoni
Copy link
Member

@magicmatatjahu gonna merge this for you 😄

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni
Copy link
Member

Someone removed <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->, so had to manually re-add it.

@magicmatatjahu
Copy link
Member

@jonaslagoni I removed it at the beginning of the file and add it to the end 😅 I had to have badges in this same line, not one under second, I took this "workaround" from one of the issues in all-contributors projects, but if it brokes the functionality so ok, and sorry for that 😅

@jonaslagoni
Copy link
Member

@jonaslagoni I removed it at the beginning of the file and add it to the end 😅 I had to have badges in this same line, not one under second, I took this "workaround" from one of the issues in all-contributors projects, but if it brokes the functionality so ok, and sorry for that 😅

Hehe, yea all-contributors dont know where to change the badge otherwise 😄 Related issue: all-contributors/all-contributors#361

@jonaslagoni jonaslagoni merged commit 47c2ea5 into master May 10, 2021
@jonaslagoni jonaslagoni deleted the all-contributors/add-magicmatatjahu branch May 10, 2021 14:53
@magicmatatjahu
Copy link
Member

magicmatatjahu commented May 10, 2021

@jonaslagoni So as I understand, the problem was with that badge was at the end, not at the beginning of file, so maybe this workaround works, but I made fakup and added it at the end? 🤣 I didn't notice any bug with this approach in mentioned issue.

@jonaslagoni
Copy link
Member

@jonaslagoni So as I understand, the problem was with that badge was at the end, not at the beginning of file, so maybe this workaround works, but I made fakup and added it at the end? 🤣 I didn't notice any bug with this approach in mentioned issue.

I mean, badges are usually displayed at the start 😄 don't know how well it looks having it in the bottom 😅 but you can try and create a PR 😄

@magicmatatjahu
Copy link
Member

@jonaslagoni It (badge) will show at the beginning, but I made reference to badge at the end of file, but it should be probably at the beginning :) I had this in my mind.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants