-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rendering of list items in markdown and bold #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@derberg could you review the PR? |
@dweber019 can you provide a screenshot of what it looks like before, how now with your PR, and the source used to display. I understood that you want to fix numbered lists but I tested you PR and still numbers show as bullets, so just want to confirm what is the expectation |
Here the yaml used asyncapi: '2.0.0'
externalDocs:
description: Find more info here
url: https://www.asyncapi.com
info:
title: Dummy example with all spec features included
version: '0.0.1'
description: |
- test
- test 2
- test 3
1. test
2. test 2
3. test 3
**bold** Here before PR: https://ibb.co/Dp6Dmfn |
@dweber019 this is what I see after using your version make sure when running generation locally during development to pass |
🤦🏼 you are right, I completely forgot about it, we need to more it to hooks one day to ease development |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 0.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @dweber019 for code |
I've put up a pull request to add @dweber019! 🎉 |
@derberg thanks and no worries. |
@dweber019 follow this PR if you want to know when the fix will be on the playground. Once it is merged, Fran will push it right after |
Description
Related issue(s)