Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of list items in markdown and bold #169

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

dweber019
Copy link
Contributor

Description

  • Fix list styling for ol and ul
  • Fix bold styling

Related issue(s)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@dweber019
Copy link
Contributor Author

@derberg could you review the PR?

@derberg
Copy link
Member

derberg commented Mar 29, 2021

@dweber019 can you provide a screenshot of what it looks like before, how now with your PR, and the source used to display. I understood that you want to fix numbered lists but I tested you PR and still numbers show as bullets, so just want to confirm what is the expectation

@dweber019
Copy link
Contributor Author

Here the yaml used

asyncapi: '2.0.0'

externalDocs:
  description: Find more info here
  url: https://www.asyncapi.com

info:
  title: Dummy example with all spec features included
  version: '0.0.1'
  description: |
    - test
    - test 2
    - test 3

    1. test
    2. test 2
    3. test 3

    **bold**

Here before PR: https://ibb.co/Dp6Dmfn
and now: https://ibb.co/7Sdspr0

@derberg
Copy link
Member

derberg commented Mar 30, 2021

@dweber019 this is what I see after using your version

Screenshot 2021-03-30 at 10 31 02

make sure when running generation locally during development to pass --install flag to make sure that not cache is used, also validate with --debug what template from what location is used.

@dweber019
Copy link
Contributor Author

Did you run npm run generate:assets?
As far as I understood the command npm run generate:assets is not part of the PR as seen in e7e6629. It's part of the chore(release) bot right? df9c9c7

@derberg
Copy link
Member

derberg commented Mar 30, 2021

🤦🏼 you are right, I completely forgot about it, we need to more it to hooks one day to ease development

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg derberg merged commit 635b664 into asyncapi:master Mar 30, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Mar 30, 2021

@all-contributors please add @dweber019 for code

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @dweber019! 🎉

@dweber019
Copy link
Contributor Author

@derberg thanks and no worries.

@derberg
Copy link
Member

derberg commented Mar 30, 2021

@dweber019 follow this PR if you want to know when the fix will be on the playground. Once it is merged, Fran will push it right after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants