Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multiple .env files. #683

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

AkhilJ321
Copy link
Contributor

Description

  • Added Support for multiple .env files.
  • Added Documentation for the same.

Related issue(s)
Fixes: #638

@AkhilJ321 AkhilJ321 changed the title feat: Added support for multiple .env files. feat: add support for multiple .env files. Jan 9, 2024
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkhilJ321 Please resolve the conflicts. btw, have you tested it?

@AkhilJ321
Copy link
Contributor Author

@KhudaDad414 yes , I tested it through a example where npm run dev used development env and on npm run start used production env.

@AkhilJ321 AkhilJ321 closed this Jan 12, 2024
@AkhilJ321 AkhilJ321 reopened this Jan 12, 2024
@AkhilJ321
Copy link
Contributor Author

@KhudaDad414 ,I am not getting what to remove, I have only removed dotenv imports and added next/env. What confict is to be resolved ,can you help me with this one

@KhudaDad414
Copy link
Member

@AkhilJ321 Conflicts happen when someone makes a change to a file that you are working on in your PR. because GitHub doesn't know which changes it should keep.

what conflict is: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/about-merge-conflicts
how to resolve the conflict: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AkhilJ321
Copy link
Contributor Author

@KhudaDad414 Thank you for the help, resolved the conflict.

@AkhilJ321 AkhilJ321 requested a review from KhudaDad414 January 16, 2024 04:01
@KhudaDad414
Copy link
Member

/rtm

@KhudaDad414
Copy link
Member

thanks for the contribution @AkhilJ321 🙇

@asyncapi-bot asyncapi-bot merged commit 3a7daca into asyncapi:master Jan 16, 2024
11 checks passed
@KhudaDad414
Copy link
Member

@allcontributors please add @AkhilJ321 for code

Copy link
Contributor

@KhudaDad414

I've put up a pull request to add @AkhilJ321! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

oviecodes pushed a commit to oviecodes/glee that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Multiple .env Files
3 participants