Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: spec v3 support (update examples to v3.0.0) #549

Merged
merged 44 commits into from
May 1, 2024
Merged

feat: spec v3 support (update examples to v3.0.0) #549

merged 44 commits into from
May 1, 2024

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Oct 23, 2023 •
edited
Loading

Description
This PR aims to update all the examples with spec V3
Related issue(s)

Fixes #457

Souvikns and others added 30 commits September 20, 2023 14:58
@Souvikns
feat: update parser-js to v2
c7ba693
@Souvikns
chore: fixing tests
5c90e5b
@Souvikns
fix the tests
c6d4136
@Souvikns
feat: updating adapters
c7d50d0
@Souvikns
Update client.ts
35a7c68
@Souvikns
fix: some minor issues
523b527
@Souvikns
fix: code smells
0d6f324
@Souvikns
fix: minor issues with parsing
55881a9
@Souvikns
fix: migration mistakes
1181316
@Souvikns
fix: security
e1c12f5
@Souvikns
fix: channelName and address
ddd88f3
@Souvikns
Update index.ts
acdb3dd
@Souvikns
Update client.ts
5124aa7
@Souvikns
fix: update parser to latest pre release
93e6466
@Souvikns
fix: review changes.
1f6ccb5
@Souvikns
Merge remote-tracking branch 'upstream/master' into update-parser
bd0d57a
@Souvikns
Update client.ts
c5828af
@Souvikns
fix: reverting markdown template
4f48945
@Souvikns
fix: review suggestions
893a03b
@KhudaDad414
ignore docs generation for dummy.
617a15c
@KhudaDad414
better error message
a7aec69
@KhudaDad414
improve types for flight-management example
9ddc198
@KhudaDad414
ignore docs
f2ca30b
@KhudaDad414
upgrade package-lock
cfb3b15
@KhudaDad414
resolve small bug
e9b991d
@KhudaDad414
fix(hopefully) test error
4a6eff5
@KhudaDad414
ci: upgrade test coverage
8bd20ed
@KhudaDad414
discard changes in coverall
c92ac97
@KhudaDad414
Merge remote-tracking branch 'upstream/master' into pr/Souvikns/523
b3f57c0
@Souvikns
Update adapter.ts
cd0801d
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@Souvikns Souvikns marked this pull request as ready for review January 9, 2024 11:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7488101682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.884%
Totals Coverage Status
Change from base Build 7487599480: 0.0%
Covered Lines: 388
Relevant Lines: 483
💛 - Coveralls

KhudaDad414
KhudaDad414 requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Souvikns I think for each of the examples we need a README file that explains what the project is and how it can be run.

@Souvikns Souvikns changed the title feat: spec v3 support feat: spec v3 support (update examples to v3.0.0) Jan 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@Souvikns Souvikns requested a review from KhudaDad414 March 22, 2024 08:33
@KhudaDad414 KhudaDad414 requested review from fmvilas and derberg April 4, 2024 21:42
@KhudaDad414
Copy link
Member

@fmvilas waiting for your review... 🙇

fmvilas
fmvilas approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit d8e3bd7 into asyncapi:master May 1, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhudaDad414 KhudaDad414 KhudaDad414 approved these changes

@fmvilas fmvilas fmvilas approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@derberg derberg Awaiting requested review from derberg

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncAPI spec v3 support in Glee
6 participants
@Souvikns @coveralls @KhudaDad414 @asyncapi-bot @fmvilas @derberg