-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: glee authentication v1 #460
Conversation
glee authentication
We should have a separate place for AuthenticationWe could have a separate place for authentication, instead of lifecycle events and config. We can have both server auth and client auth in the same place. /** auth/serverName.ts **/
export function serverAuth({headers, done}) {
// write logic for authentication
done()
}
export function clientAuth() {
return {
username: '',
password: ''
}
}
|
@Souvikns That's a good approach, we'll have to create a separate folder for One thing on my mind is: |
@Souvikns that's a great idea. it would solve lots of issues and makes a lot of sense.
@oviecodes For now lets focus on HTTP and WS. that's our goal for GSoC. we can extend it if the need arise. |
@oviecodes thanks to @Souvikns the formatting issue should be fixed with #469 the formatting issue seems to be solved. let's move your changes to a new PR so we can discuss it further. 😀 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
This PR continues the discussion on the glee authentication issue #377
We have moved on from the middleware approach proposed in PR #439 and have started exploring the possibilities of using
lifecycle events
for authentication. This PR details the progress that has been made using Lifecycle events.Progress:
onAuth
)auth
event from websocket serverChallenges:
We're currently experimenting with potential fixes for this challenge.
Related issue(s)
Discuses issue #377
@Souvikns @KhudaDad414