Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support HTTP/SaaS function trigger #372

Closed
wants to merge 29 commits into from

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Jan 10, 2023

Description

  • Adds invoke alongside reply and send. invoke can trigger HTTP/HTTPS endpoints. It enables Glee to support FaaS functions.
  • invoke can also be configured by setting the operationId to the URL of the FaaS function and customising it with an x-glee-invoke extension.
  • Adds a prettier config file so we can enforce the formatting rules.
  • Moves some misplaced dependencies to devDependencies.
  • Create a prettier config file so we can enforce some styling rules that are not being enforced by es-lint.

Related issue(s)
Fixes #25

package.json Outdated Show resolved Hide resolved
@fmvilas
Copy link
Member

fmvilas commented Jan 23, 2023

@KhudaDad414 did you close it accidentally or?

@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Jan 23, 2023

@fmvilas I reset the branch since I am taking a different approach and I guess GitHub closed it automatically. 😆 I will reopen this soon.

@KhudaDad414 KhudaDad414 reopened this Jan 23, 2023
@coveralls
Copy link

coveralls commented Jan 23, 2023

Pull Request Test Coverage Report for Build 3996539920

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 61.905%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/util.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/util.ts 1 89.19%
src/lib/configs.ts 22 17.98%
Totals Coverage Status
Change from base Build 3932357278: -1.1%
Covered Lines: 316
Relevant Lines: 436

💛 - Coveralls

src/lib/functions.ts Outdated Show resolved Hide resolved
@KhudaDad414 KhudaDad414 marked this pull request as ready for review January 31, 2023 12:18
@KhudaDad414 KhudaDad414 requested a review from fmvilas January 31, 2023 12:18
@KhudaDad414
Copy link
Member Author

@Souvikns would love to have your opinion here. 🙇

Souvikns
Souvikns previously approved these changes Jan 31, 2023
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, really like how you are generating functions from the spec to use existing triggerFunction logic

@KhudaDad414
Copy link
Member Author

@fmvilas a review would be appreciated. 🙇

docs/functions.md Outdated Show resolved Hide resolved
docs/functions.md Outdated Show resolved Hide resolved
docs/functions.md Outdated Show resolved Hide resolved
docs/functions.md Outdated Show resolved Hide resolved
docs/functions.md Show resolved Hide resolved
docs/functions.md Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Fran Méndez <[email protected]>
KhudaDad414 and others added 2 commits February 23, 2023 14:20
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
@KhudaDad414
Copy link
Member Author

@fmvilas suggested changes have been applied. a 👁️ would be 🙏.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 12, 2023
@KhudaDad414 KhudaDad414 removed the stale label Aug 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KhudaDad414
Copy link
Member Author

@Souvikns @fmvilas another round of review 🙇

@fmvilas
Copy link
Member

fmvilas commented Sep 6, 2023

You got conflicts again 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

@KhudaDad414
Copy link
Member Author

@fmvilas conflicts have been resolved.

@KhudaDad414
Copy link
Member Author

closing this for two reasons:

  1. Since all of the remote servers should be included in the AsyncAPI file, If somebody wants this feature they can already do this by including the SaaS/HTTP endpoint as an http server and glee will handle it with the http client adapter.

  2. Glee should support the functionalities that are provided by the spec first then we can think about side cases.

@KhudaDad414 KhudaDad414 closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for an HTTP/FaaS runtime
4 participants