-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support HTTP/SaaS function trigger #372
Conversation
516c09b
to
0bbde49
Compare
@KhudaDad414 did you close it accidentally or? |
@fmvilas I reset the branch since I am taking a different approach and I guess GitHub closed it automatically. 😆 I will reopen this soon. |
Pull Request Test Coverage Report for Build 3996539920Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@Souvikns would love to have your opinion here. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, really like how you are generating functions from the spec to use existing triggerFunction
logic
@fmvilas a review would be appreciated. 🙇 |
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
@fmvilas suggested changes have been applied. a 👁️ would be 🙏. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
You got conflicts again 😄 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@fmvilas conflicts have been resolved. |
closing this for two reasons:
|
Description
invoke
alongsidereply
andsend
.invoke
can trigger HTTP/HTTPS endpoints. It enables Glee to support FaaS functions.invoke
can also be configured by setting theoperationId
to the URL of the FaaS function and customising it with anx-glee-invoke
extension.dependencies
todevDependencies
.Related issue(s)
Fixes #25