Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change variable name from 'servers' to 'channels' #368

Merged
merged 5 commits into from
Dec 21, 2022
Merged

refactor: change variable name from 'servers' to 'channels' #368

merged 5 commits into from
Dec 21, 2022

Conversation

Ankitchaudharyy
Copy link
Contributor

Description
Issue : #360
Changed variable name to channels.

Related issue(s)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3731121349

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%
Totals Coverage Status
Change from base Build 3694500284: 0.0%
Covered Lines: 287
Relevant Lines: 313
💛 - Coveralls

@Ankitchaudharyy Ankitchaudharyy changed the title Change variable name from 'servers' to 'channels' refactor: Change variable name from 'servers' to 'channels' Dec 19, 2022
@Ankitchaudharyy Ankitchaudharyy changed the title refactor: Change variable name from 'servers' to 'channels' refactor: change variable name from 'servers' to 'channels' Dec 19, 2022
fmvilas
fmvilas approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@fmvilas
Copy link
Member

fmvilas commented Dec 21, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 2ce0735 into asyncapi:master Dec 21, 2022
Ruchip16 pushed a commit to Ruchip16/glee that referenced this pull request Jan 12, 2023
@Ankitchaudharyy @ankitchaudharyy-TW @Ruchip16
refactor: change variable name from 'servers' to 'channels' (asyncapi…
2592cfd 
…#368)

Co-authored-by: ankitchaudharyy-TW <[email protected]>
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ankitchaudharyy @coveralls @fmvilas @asyncapi-bot @ankitchaudharyy-TW